From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
Subject: Re: [PATCH 1/12] BE NIC driver - header and initialization functions
Date: Thu, 05 Jun 2008 10:20:27 -0700
Message-ID: <4848205B.9090903@intel.com>
References: <20080605163420.211f624e@mailhost.serverengines.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: Subbu Seetharaman <subbus@serverengines.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga02.intel.com ([134.134.136.20]:51398 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751774AbYFERVH (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 5 Jun 2008 13:21:07 -0400
In-Reply-To: <20080605163420.211f624e@mailhost.serverengines.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Subbu Seetharaman wrote:
> I am submitting the BladeEngine NIC driver for acceptance in the
> kernel tree.  This submission implements the comments from
> Stephen in the third round of review (including shorter
> function comments).  Thanks.


Subject: [PATCH 1/12] BE NIC driver - header and initialization functions

ew. please use the semicolon in the subject line like everyone else, and use the
module name as the subsys/driver name (suggested).

[PATCH 1/12] benet: header and initialization functions


This seems to be the most widely used convention, and will help people find your code.

Cheers,

Auke