From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs interface implementation for the driver Date: Fri, 06 Jun 2008 00:54:49 +0200 Message-ID: <48486EB9.4010706@trash.net> References: <20080529095126.9943.84692.stgit@localhost.localdomain> <20080529095754.9943.27936.stgit@localhost.localdomain> <20080529103003.010c4a08@extreme> <20080529174805.GA10903@kroah.com> <1212518703.2217.22.camel@lap75545.ornl.gov> <20080605054035.GA8059@ornl.gov> <20080605100103.38ce7c4b@extreme> <4848234B.1080200@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Amar Mudrankit , Dave Dillow , Greg KH , general@lists.openfabrics.org, netdev@vger.kernel.org, Stephen Hemminger , poornima.kamath@qlogic.com To: Roland Dreier Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: general-bounces@lists.openfabrics.org Errors-To: general-bounces@lists.openfabrics.org List-Id: netdev.vger.kernel.org Roland Dreier wrote: > > > There is nothing stopping adding a well designed alternate interface. > > > Either netlink or ioctl's are okay. As long as it is 32/64 bit clean. > > > From a quick look it seems it should use rtnl_link instead > > of adding yet another private sysfs interface. > > This seems crazy -- why do we want to push things towards the complexity > of rtnl_link instead of a simple text-based interface that can be > trivial used with 'echo' from the shell? Its not complicated at all. Ability to use "echo" seems like a pretty poor argument to me. > What advantages does that give? - atomic configuration changes - atomic configuration dumps - configuration change notifications - same interface as for all other network-related configurations - easily extensible - not yet another private driver interface - not text based, which makes it a lot more convenient for using in programs