netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Adrian Bunk <adrian.bunk@movial.fi>,
	netdev@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] 85xx: MPC85xx MDS - Unconditionally select PHYLIB for board fixups
Date: Fri, 06 Jun 2008 13:48:44 -0400	[thread overview]
Message-ID: <4849787C.8090506@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0806061039390.13744@blarg.am.freescale.net>

Kumar Gala wrote:
> The MPC85xx MDS board requires some board level tweaks of the PHYs that
> either the eTSEC (gianfar) or UCC ethernet controllers are connected to.
> 
> Its possible to build the phylib as a module, however this breaks the
> board level fix ups because phy_read and phy_write are not available
> if we build as a module.
> 
> So we unconditionally select PHYLIB to ensure its built into the kernel
> if we are building in MPC85xx MDS support.  This was determined to be
> the easiest soultion even though it prevents the user from removing
> PHYLIB support if they decide they don't want it.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> 
> will go via the powerpc.git tree for 2.6.26.
> 
> - k
> 
>  arch/powerpc/platforms/85xx/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
> index 7ff29d5..ecbe580 100644
> --- a/arch/powerpc/platforms/85xx/Kconfig
> +++ b/arch/powerpc/platforms/85xx/Kconfig
> @@ -34,6 +34,7 @@ config MPC85xx_MDS
>  	bool "Freescale MPC85xx MDS"
>  	select DEFAULT_UIMAGE
>  	select QUICC_ENGINE
> +	select PHYLIB
>  	help

ACK



      reply	other threads:[~2008-06-06 17:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 15:58 [PATCH] phylib: Don't allow core of phylib to build as a module Kumar Gala
2008-06-02 16:03 ` Jeff Garzik
2008-06-02 16:25   ` Kumar Gala
2008-06-02 16:32     ` Scott Wood
2008-06-02 16:39     ` Jeff Garzik
2008-06-02 19:19       ` Kumar Gala
2008-06-02 20:29         ` Jeff Garzik
2008-06-02 23:06           ` Kumar Gala
2008-06-02 19:30       ` Kumar Gala
2008-06-02 19:44         ` Andy Fleming
2008-06-02 20:30           ` Jeff Garzik
2008-06-02 23:07             ` Kumar Gala
2008-06-02 23:20               ` Scott Wood
2008-06-03 14:47                 ` [RFC] Make board force selection of PHYLIB Kumar Gala
2008-06-03 15:10                   ` Scott Wood
2008-06-03 15:14                     ` Kumar Gala
2008-06-03 15:18                       ` Scott Wood
2008-06-03 15:31                         ` Kumar Gala
2008-06-03 15:36                           ` Scott Wood
2008-06-03 15:40                             ` Kumar Gala
2008-06-03 15:56                               ` Scott Wood
2008-06-03 18:07                           ` Andy Fleming
2008-06-03 17:00                   ` Adrian Bunk
2008-06-03 18:11                     ` Andy Fleming
2008-06-03 18:23                     ` Kumar Gala
2008-06-06 15:19                 ` [PATCH] phylib: Don't allow core of phylib to build as a module Grant Likely
2008-06-02 16:54     ` Adrian Bunk
2008-06-02 19:24       ` Kumar Gala
2008-06-06 15:40         ` [PATCH] [POWERPC] 85xx: MPC85xx MDS - Unconditionally select PHYLIB for board fixups Kumar Gala
2008-06-06 17:48           ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4849787C.8090506@garzik.org \
    --to=jeff@garzik.org \
    --cc=adrian.bunk@movial.fi \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).