From: Shan Wei <shanwei@cn.fujitsu.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [RFC][PATCH 3/3] IPv4:Check IP_MULTICAST_LOOP option value
Date: Tue, 10 Jun 2008 15:51:47 +0800 [thread overview]
Message-ID: <484E3293.8000507@cn.fujitsu.com> (raw)
The IP_MULTICAST_LOOP option can only be set with o or 1. When
other valuse are set, the kernel should return an error of EINVAL.
In addition, the option should not be uesd by SOCK_STREAM type,
same as IP_MULTICAST_IF, IP_MULTICAST_TTL.
But the kernel doesn't check them.
Signed-off-by: Shan Wei<shanwei@cn.fujitsu.com>
---
net/ipv4/ip_sockglue.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index e0514e8..82196a5 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -558,8 +558,12 @@ static int do_ip_setsockopt(struct sock *sk, int level,
inet->mc_ttl = val;
break;
case IP_MULTICAST_LOOP:
+ if (sk->sk_type == SOCK_STREAM)
+ goto e_inval;
if (optlen<1)
goto e_inval;
+ if (val < 0 || val > 1)
+ goto e_inval;
inet->mc_loop = !!val;
break;
case IP_MULTICAST_IF:
--
1.5.4.4
next reply other threads:[~2008-06-10 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 7:51 Shan Wei [this message]
2008-06-10 8:15 ` [RFC][PATCH 3/3] IPv4:Check IP_MULTICAST_LOOP option value YOSHIFUJI Hideaki / 吉藤英明
2008-06-10 8:32 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-10 8:32 ` Shan Wei
2008-06-10 8:42 ` YOSHIFUJI Hideaki / 吉藤英明
2008-06-10 9:07 ` Shan Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484E3293.8000507@cn.fujitsu.com \
--to=shanwei@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).