From: James Chapman <jchapman@katalix.com>
To: David Miller <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: pppoe: Unshare skb before anything else
Date: Tue, 10 Jun 2008 22:44:02 +0100 [thread overview]
Message-ID: <484EF5A2.4060503@katalix.com> (raw)
In-Reply-To: <20080610.140925.199998975.davem@davemloft.net>
David Miller wrote:
> From: James Chapman <jchapman@katalix.com>
> Date: Sun, 08 Jun 2008 11:08:59 +0100
>
>> Herbert Xu wrote:
>>> Hi Dave:
>>>
>>> I noticed that my last patch to move the unshare in pppoe missed
>>> the other spot which did the same thing:
>>>
>>> pppoe: Unshare skb before anything else
>>>
>>> We need to unshare the skb first as otherwise pskb_may_pull may
>>> write to a shared skb which could be bad.
>> The same problem exists in the pppol2tp driver. Patch to follow. I'm
>> also fixing the copy-to-iovec issue.
>
> I have the iovec patch, but I do not see the unshare one.
> Did you post it? Please resend if you have since I
> don't have a copy.
I didn't send the patch. I realised when I was writing it that in L2TP's
case, the unshare isn't needed because L2TP uses UDP encap sockets.
Sorry I forgot to let Herbert and netdev know.
--
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development
next prev parent reply other threads:[~2008-06-10 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 6:29 pppoe: Unshare skb before anything else Herbert Xu
2008-06-08 10:08 ` James Chapman
2008-06-10 21:09 ` David Miller
2008-06-10 21:44 ` James Chapman [this message]
2008-06-10 22:01 ` David Miller
2008-06-10 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484EF5A2.4060503@katalix.com \
--to=jchapman@katalix.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).