* [PATCH] sfc: Recover from RX queue flush failure
[not found] <cover.1213035645.git.bhutchings@solarflare.com>
@ 2008-06-09 18:34 ` Ben Hutchings
2008-06-10 22:22 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2008-06-09 18:34 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, linux-net-drivers
From: Steve Hodgson <shodgson@solarflare.com>
RX queue flush can fail if traffic continues to arrive. Recover by
performing an invisible reset.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/falcon.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
index cbe2e83..f2d361f 100644
--- a/drivers/net/sfc/falcon.c
+++ b/drivers/net/sfc/falcon.c
@@ -842,8 +842,10 @@ void falcon_fini_rx(struct efx_rx_queue *rx_queue)
continue;
break;
}
- if (rc)
+ if (rc) {
EFX_ERR(efx, "failed to flush rx queue %d\n", rx_queue->queue);
+ efx_schedule_reset(efx, RESET_TYPE_INVISIBLE);
+ }
/* Remove RX descriptor ring from card */
EFX_ZERO_OWORD(rx_desc_ptr);
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sfc: Recover from RX queue flush failure
2008-06-09 18:34 ` [PATCH] sfc: Recover from RX queue flush failure Ben Hutchings
@ 2008-06-10 22:22 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-06-10 22:22 UTC (permalink / raw)
To: Ben Hutchings; +Cc: netdev, linux-net-drivers
Ben Hutchings wrote:
> From: Steve Hodgson <shodgson@solarflare.com>
>
> RX queue flush can fail if traffic continues to arrive. Recover by
> performing an invisible reset.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/sfc/falcon.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-10 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1213035645.git.bhutchings@solarflare.com>
2008-06-09 18:34 ` [PATCH] sfc: Recover from RX queue flush failure Ben Hutchings
2008-06-10 22:22 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).