From: hujunwei <hujunwei4@huawei.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: <wensong@linux-vs.org>, <horms@verge.net.au>,
<pablo@netfilter.org>, <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>, <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
<lvs-devel@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
<coreteam@netfilter.org>, Mingfangsen <mingfangsen@huawei.com>,
<wangxiaogang3@huawei.com>, <xuhanbing@huawei.com>
Subject: Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl
Date: Wed, 31 Jul 2019 23:58:49 +0800 [thread overview]
Message-ID: <484fef63-710a-701e-3151-eefaf3b9b1ca@huawei.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1907302226340.4897@ja.home.ssi.bg>
Hello, Julian
On 2019/7/31 3:29, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 30 Jul 2019, hujunwei wrote:
>
>> From: Junwei Hu <hujunwei4@huawei.com>
>>
>> The ipvs module parse the user buffer and save it to sysctl,
>> then check if the value is valid. invalid value occurs
>> over a period of time.
>> Here, I add a variable, struct ctl_table tmp, used to read
>> the value from the user buffer, and save only when it is valid.
>> I delete proc_do_sync_mode and use extra1/2 in table for the
>> proc_dointvec_minmax call.
>>
>> Fixes: f73181c8288f ("ipvs: add support for sync threads")
>> Signed-off-by: Junwei Hu <hujunwei4@huawei.com>
>
> Looks good to me, thanks!
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
>
> BTW, why ip_vs_zero_all everywhere? Due to old git version?
>
I will update the git version and send the patch v3.
Regards,
Junwei
next prev parent reply other threads:[~2019-07-31 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:48 [PATCH net] ipvs: Improve robustness to the ipvs sysctl hujunwei
2019-07-30 7:11 ` [PATCH net v2] " hujunwei
2019-07-30 19:29 ` Julian Anastasov
2019-07-31 15:58 ` hujunwei [this message]
2019-07-31 16:03 ` [PATCH net v3] " hujunwei
2019-07-31 17:53 ` Julian Anastasov
2019-08-03 16:40 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484fef63-710a-701e-3151-eefaf3b9b1ca@huawei.com \
--to=hujunwei4@huawei.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@blackhole.kfki.hu \
--cc=lvs-devel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wangxiaogang3@huawei.com \
--cc=wensong@linux-vs.org \
--cc=xuhanbing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).