* [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
@ 2008-05-15 21:26 Christophe Jaillet
2008-05-15 21:31 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christophe Jaillet @ 2008-05-15 21:26 UTC (permalink / raw)
To: cj, linux, florian.fainelli, netdev
From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Hi, here is a patch against linux/drivers/net/r6040.c.
Compared to other places in the kernel, I think that this driver misuses
the function round_jiffies.
Note: this patch is based on 'linux-2.6.25.tar.bz2'
Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
---
--- linux 2.6.25/drivers/net/r6040.c 2008-05-15 23:21:28.000000000 +0200
+++ linux 2.6.25/drivers/net/r6040.c.cj 2008-05-15 22:16:44.000000000 +0200
@@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da
}
/* Timer active again */
- mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
+ mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
}
/* Read/set MAC address routines */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
2008-05-15 21:26 [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ??? Christophe Jaillet
@ 2008-05-15 21:31 ` Florian Fainelli
2008-05-15 21:43 ` Arjan van de Ven
2008-06-12 2:50 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2008-05-15 21:31 UTC (permalink / raw)
To: Christophe Jaillet, Francois Romieu; +Cc: linux, netdev
Hello Christophe,
Le Thursday 15 May 2008 23:26:22 Christophe Jaillet, vous avez écrit :
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/net/r6040.c.
>
> Compared to other places in the kernel, I think that this driver misuses
> the function round_jiffies.
You are right, thanks for this fix.
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Acked-by: Florian Fainelli <florian.fainelli@telecomint.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
2008-05-15 21:26 [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ??? Christophe Jaillet
2008-05-15 21:31 ` Florian Fainelli
@ 2008-05-15 21:43 ` Arjan van de Ven
2008-06-12 2:50 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2008-05-15 21:43 UTC (permalink / raw)
To: Christophe Jaillet; +Cc: cj, linux, florian.fainelli, netdev
On Thu, 15 May 2008 23:26:22 +0200
"Christophe Jaillet" <christophe.jaillet@wanadoo.fr> wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/net/r6040.c.
>
> Compared to other places in the kernel, I think that this driver
> misuses the function round_jiffies.
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> ---
>
> --- linux 2.6.25/drivers/net/r6040.c 2008-05-15
> 23:21:28.000000000 +0200 +++ linux
> 2.6.25/drivers/net/r6040.c.cj 2008-05-15 22:16:44.000000000
> +0200 @@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da }
>
> /* Timer active again */
> - mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
> + mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
> }
>
good catch!
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
2008-05-15 21:26 [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ??? Christophe Jaillet
2008-05-15 21:31 ` Florian Fainelli
2008-05-15 21:43 ` Arjan van de Ven
@ 2008-06-12 2:50 ` Jeff Garzik
2 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2008-06-12 2:50 UTC (permalink / raw)
To: Christophe Jaillet; +Cc: linux, florian.fainelli, netdev
Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against linux/drivers/net/r6040.c.
>
> Compared to other places in the kernel, I think that this driver misuses
> the function round_jiffies.
>
>
> Note: this patch is based on 'linux-2.6.25.tar.bz2'
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
applied
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-12 2:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-15 21:26 [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ??? Christophe Jaillet
2008-05-15 21:31 ` Florian Fainelli
2008-05-15 21:43 ` Arjan van de Ven
2008-06-12 2:50 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).