From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
linux-sctp@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] SCTP: enable cookie-echo retransmission transport switch
Date: Thu, 12 Jun 2008 11:07:16 -0400 [thread overview]
Message-ID: <48513BA4.9030403@hp.com> (raw)
In-Reply-To: <4850A7F2.6090906@cn.fujitsu.com>
Gui Jianfeng wrote:
> Vlad,
> This patch enables cookie-echo retransmission transport switch
> feature. If COOKIE-ECHO retransmission happens, it will be sent
> to the address other than the one last sent to.
>
NAK.
You can't blindly choose a different transport since they could
be unconfirmed and can't really be used until we confirm them
with HBs. So, you can only do this when the user issued an
sctp_connectx() and we have multiple confirmed transports.
In this case only confirmed transports are allowed, otherwise
there is a possibility of hijacking associations.
Also, looking at this, the same problem exists in current
code for selection INIT transports.
We don't correctly treat peers passed to connectx() as confirmed
and don't select the correct transport.
Once you fix that above, you can just re-use the function and
re-use init_last_sent_to.
-vlad
next prev parent reply other threads:[~2008-06-12 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 4:37 [PATCH] SCTP: enable cookie-echo retransmission transport switch Gui Jianfeng
2008-06-12 15:07 ` Vlad Yasevich [this message]
2008-06-13 0:47 ` Gui Jianfeng
2008-06-13 12:57 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48513BA4.9030403@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=guijianfeng@cn.fujitsu.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).