netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: for.poige+linux@gmail.com, netdev@vger.kernel.org
Subject: Re: re-formated /Re: Hi!Couldn't you take a look at kernel stack's trace? (ip_route_input+0x91a/0xcc9)/
Date: Thu, 12 Jun 2008 21:36:45 +0200	[thread overview]
Message-ID: <48517ACD.4020209@gmail.com> (raw)
In-Reply-To: <485115EE.1040204@trash.net>

Patrick McHardy wrote, On 06/12/2008 02:26 PM:

> Igor Podlesny wrote:
>> 2008/6/12 Patrick McHardy <kaber@trash.net>:
>>>> Igor Podlesny wrote:
>>>>>>  Pid: 8, comm: sirq-net-rx/0 Not tainted (2.6.25.4-rt4aa-gcc43 #1)
>>                                             ^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> 	(2.6.25.4-rt4aa-gcc43)
>> 	
>> 	-RT is real-time: http://rt.wiki.kernel.org/index.php/Main_Page

Hi,

Maybe I got something wrong but it seems to be this place:

static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
                               u8 tos, struct net_device *dev)
...
        if (!IN_DEV_FORWARD(in_dev))
                goto e_hostunreach;
        if (res.type != RTN_UNICAST)
                goto martian_destination;

        err = ip_mkroute_input(skb, &res, &fl, in_dev, daddr, saddr, tos);
done:
        in_dev_put(in_dev);
        if (free_res)
                fib_res_put(&res);	<------------
out:    return err;
=====
static inline void fib_res_put(struct fib_result *res)
{
        if (res->fi)
                fib_info_put(res->fi);	<------------
#ifdef CONFIG_IP_MULTIPLE_TABLES
        if (res->r)
                fib_rule_put(res->r);
#endif
}
=====
static inline void fib_info_put(struct fib_info *fi)
{
        if (atomic_dec_and_test(&fi->fib_clntref))	<---------
                free_fib_info(fi);
}

Looks like EDX: 00000001 is fi, and fi + 0x18 is for fib_clntref,
but I didn't track it further.

Igor, probably for this list it's more interesting if it's reproducible
with unpatched kernels, and if you tried other than 2.6.25 versions
for this?

Thanks,
Jarek P.

  reply	other threads:[~2008-06-12 19:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 14:36 re-formated /Re: Hi!Couldn't you take a look at kernel stack's trace? (ip_route_input+0x91a/0xcc9)/ Igor Podlesny
2008-06-12 12:07 ` Patrick McHardy
2008-06-12 12:24   ` Igor Podlesny
2008-06-12 12:26     ` Patrick McHardy
2008-06-12 19:36       ` Jarek Poplawski [this message]
2008-06-12 19:46         ` > with unpatched kernels, and if you tried other than 2.6.25 versions Igor M Podlesny
2008-06-12 20:15           ` Jarek Poplawski
2008-06-12 20:19             ` > Hm... hard to tell. This shouldn't happen and rebooting isn't a solution Igor M Podlesny
2008-06-12 20:49               ` Jarek Poplawski
2008-06-12 20:51                 ` > OK, a reboot after a bug can sometimes prevent further data corruption/loss Igor M Podlesny
2008-06-12 21:04                   ` Jarek Poplawski
2008-06-12 20:21             ` > try a more current kernel (e.g. 2.6.26-rc5) Igor M Podlesny
2008-06-12 20:39               ` Stephen Hemminger
2008-06-12 20:44                 ` > And kernel developer's can not afford debugging closed source drivers Igor M Podlesny
2008-06-12 20:23             ` > this message has strange "Subject" Igor M Podlesny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48517ACD.4020209@gmail.com \
    --to=jarkao2@gmail.com \
    --cc=for.poige+linux@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).