From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [RESEND #3/patch 2.6.26-rc6] net/enc28j60: low power mode Date: Fri, 13 Jun 2008 05:40:56 -0400 Message-ID: <485240A8.5070802@garzik.org> References: <200806122138.06674.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Claudio Lanconelli , lkml , Andrew Morton To: David Brownell Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:40395 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753431AbYFMJlC (ORCPT ); Fri, 13 Jun 2008 05:41:02 -0400 In-Reply-To: <200806122138.06674.david-b@pacbell.net> Sender: netdev-owner@vger.kernel.org List-ID: David Brownell wrote: > Keep enc28j60 chips in low-power mode when they're not in use. > At typically 120 mA, these chips run hot even when idle; this > low power mode cuts that power usage by a factor of around 100. > > This version provides a generic routine to poll a register until > its masked value equals some value ... e.g. bit set or cleared. > It's basically what the previous wait_phy_ready() did, but this > version is generalized to support the handshaking needed to > enter and exit low power mode. > > Signed-off-by: David Brownell > Signed-off-by: Claudio Lanconelli > --- > Previously sent: 18-May, 19-February; there were several > previous iterations too ... > > drivers/net/enc28j60.c | 82 ++++++++++++++++++++++++++++++++++--------------- > 1 file changed, 58 insertions(+), 24 deletions(-) I've put these two into my queue, so they are definitely in process now. For netdev patches it helps to CC me, since not every patch sent solely to netdev@ is a to-be-applied patch, and might be missed -- or quite often, assumed to be a patch that warrants discussion. Jeff