From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Newall Subject: Re: [PATCH 1/2] 8139too: clean up spaces and TABs Date: Sun, 15 Jun 2008 15:51:24 +0930 Message-ID: <4854B4E4.1060903@davidnewall.com> References: <4853BB62.1060109@freemail.hu> <4853C8AD.9020407@s5r6.in-berlin.de> <48541165.7050304@freemail.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Stefan Richter , Jeff Garzik , netdev@vger.kernel.org, Trivial Patch Monkey , LKML To: =?ISO-8859-1?Q?N=E9meth_M=E1rton?= Return-path: Received: from eth7959.sa.adsl.internode.on.net ([150.101.82.22]:44207 "EHLO hawking.rebel.net.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751391AbYFOGVa (ORCPT ); Sun, 15 Jun 2008 02:21:30 -0400 In-Reply-To: <48541165.7050304@freemail.hu> Sender: netdev-owner@vger.kernel.org List-ID: These patches, which simply play around with white space, are undesirable, in my opinion. It doesn't make the code better, just changes the aesthetics to one that's more to your liking, and surely it makes it less pleasing to others. I see no benefit in such changes, as opposed to a certain cost and risk, which all changes carry. Every change requires an expense of other people's brain cycles, if I can put it that way, and on this sort of change, I sincerely think it's pointless. Sorry to come down all negative.