From: Jeff Garzik <jeff@garzik.org>
To: Jaswinder Singh <jaswinderlinux@gmail.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Auke Kok <auke-jan.h.kok@intel.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] firmware: convert e100 driver to request_firmware()
Date: Sun, 15 Jun 2008 14:44:08 -0400 [thread overview]
Message-ID: <485562F8.2000400@garzik.org> (raw)
In-Reply-To: <3f9a31f40806151134n1b5e4de7m2ccd9c8a9e98cdb4@mail.gmail.com>
Jaswinder Singh wrote:
> Hello Jeff,
>
> On 6/15/08, Jeff Garzik <jeff@garzik.org> wrote:
>> David Woodhouse wrote:
>>> From: Jaswinder Singh <jaswinderlinux@gmail.com>
>>>
>>> drivers/net/Kconfig | 8 +
>>> drivers/net/e100.c | 283
>>> +++++++++++-------------------------
>>> firmware/Makefile | 2 +
>>> firmware/WHENCE | 12 ++
>>> firmware/e100/d101m_ucode.bin.ihex | 38 +++++
>>> firmware/e100/d101s_ucode.bin.ihex | 38 +++++
>>> firmware/e100/d102e_ucode.bin.ihex | 38 +++++
>>> 7 files changed, 222 insertions(+), 197 deletions(-)
>>> create mode 100644 firmware/e100/d101m_ucode.bin.ihex
>>> create mode 100644 firmware/e100/d101s_ucode.bin.ihex
>>> create mode 100644 firmware/e100/d102e_ucode.bin.ihex
>> NAK - firmware should not be stored in a separate directory from the
>> driver to which it is intimately tied.
>>
>
> driver source code will goto drivers directory and firmware will goto
> firmware directory.
> Please let us know, how can we keep them in same directory.
How? It is simply a matter of changing the Makefile rules.
Each driver is _intimately_ tied to its firmware, so it only increases
headaches by separating two pieces of a single, cohesive whole.
Jeff
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next prev parent reply other threads:[~2008-06-15 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 9:42 [PATCH] firmware: convert e100 driver to request_firmware() David Woodhouse
2008-06-15 17:50 ` Jeff Garzik
2008-06-15 17:51 ` David Woodhouse
2008-06-15 18:07 ` Jeff Garzik
2008-06-15 18:34 ` Jaswinder Singh
2008-06-15 18:42 ` David Woodhouse
2008-06-15 19:00 ` Jeff Garzik
2008-06-15 18:44 ` Jeff Garzik [this message]
2008-06-15 22:09 ` David Woodhouse
2008-06-15 23:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485562F8.2000400@garzik.org \
--to=jeff@garzik.org \
--cc=auke-jan.h.kok@intel.com \
--cc=dwmw2@infradead.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jaswinderlinux@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).