From: Patrick McHardy <kaber@trash.net>
To: Benny Amorsen <benny+usenet@amorsen.dk>
Cc: netdev@vger.kernel.org, Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH,RFC] skb->network_header and __vlan_put_tag()
Date: Tue, 17 Jun 2008 14:19:38 +0200 [thread overview]
Message-ID: <4857ABDA.6050407@trash.net> (raw)
In-Reply-To: <m3prqgpe1e.fsf@ursa.amorsen.dk>
[Don't trim CC lists please]
Benny Amorsen wrote:
> Lennert Buytenhek <buytenh@wantstofly.org> writes:
>
>> I'm adding VLAN support to mv643xx_eth (which does not support HW
>> insertion of a VLAN tag, but it does support HW checksumming when
>> a VLAN tag is present, you just have to tell the HW how many bytes
>> there are between the start of the packet and the IP header), and
>> I'm ending up with code like this:
>>
>> if (skb->protocol == htons(ETH_P_8021Q))
>> ip_header = ip_hdr(skb) + 4;
>> else
>> ip_header = ip_hdr(skb);
>
> How well does this work when doing QinQ or QinQinQ?
Currently probably doesn't work, so the patch makes even more
sense.
next prev parent reply other threads:[~2008-06-17 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 22:15 [PATCH,RFC] skb->network_header and __vlan_put_tag() Lennert Buytenhek
2008-06-17 10:10 ` Benny Amorsen
2008-06-17 12:19 ` Patrick McHardy [this message]
2008-06-17 12:18 ` Patrick McHardy
2008-07-05 18:33 ` Patrick McHardy
2008-07-07 12:05 ` Lennert Buytenhek
2008-07-07 12:17 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4857ABDA.6050407@trash.net \
--to=kaber@trash.net \
--cc=benny+usenet@amorsen.dk \
--cc=buytenh@wantstofly.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).