From: Patrick McHardy <kaber@trash.net>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: "David S. Miller" <davem@davemloft.net>, NETDEV <netdev@vger.kernel.org>
Subject: Re: v2: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow
Date: Tue, 17 Jun 2008 14:59:46 +0200 [thread overview]
Message-ID: <4857B542.6030703@trash.net> (raw)
In-Reply-To: <48568125.4090500@cn.fujitsu.com>
Wang Chen wrote:
> + if (dev->promiscuity == 0) {
> + /*
> + * Avoid overflow.
> + * If inc causes overflow, untouch promisc and return error.
> + */
> + if (inc < 0)
> + dev->flags &= ~IFF_PROMISC;
> + else {
> + dev->promiscuity -= inc;
> + printk(KERN_ERR "%s: promiscuity touches roof, "
> + "set promiscuity failed, promiscuity feature "
> + "of device will be broken.\n", dev->name);
> + return -EOVERFLOW;
> + }
> + }
Assuming the caller does proper error handling, that printk is
not true.
next prev parent reply other threads:[~2008-06-17 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 9:15 RFC: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow Wang Chen
2008-06-16 9:38 ` Patrick McHardy
2008-06-16 9:51 ` Wang Chen
2008-06-16 10:04 ` Patrick McHardy
2008-06-16 15:05 ` v2: " Wang Chen
2008-06-17 12:59 ` Patrick McHardy [this message]
2008-06-18 1:51 ` Wang Chen
2008-06-18 4:54 ` David Miller
2008-06-18 8:44 ` Patrick McHardy
2008-06-18 8:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4857B542.6030703@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).