From: "Séguier Régis" <rseguier@e-teleport.net>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
alan@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change
Date: Wed, 18 Jun 2008 01:37:08 +0200 [thread overview]
Message-ID: <48584AA4.8040801@e-teleport.net> (raw)
In-Reply-To: <20080617214538.GA6388@electric-eye.fr.zoreil.com>
Francois Romieu a écrit :
> Séguier Régis <rseguier@e-teleport.net> :
> [...]
>
>> The mtu change doesn't work :
>>
>> Jun 16 23:22:34 apollo kernel: ------------[ cut here ]------------
>> Jun 16 23:22:34 apollo kernel: WARNING: at arch/x86/kernel/pci-dma.c:482
>> dma_free_coherent+0x3a/0x9c()
>> Jun 16 23:22:34 apollo kernel: Pid: 1527, comm: ip Tainted: G W
>> 2.6.26-rc6EPIA_SN_VB7001 #3
>> Jun 16 23:22:34 apollo kernel: [<c0115fe5>] warn_on_slowpath+0x3b/0x5f
>> Jun 16 23:22:34 apollo kernel: [<c0133940>]
>> get_page_from_freelist+0x24a/0x36f
>> Jun 16 23:22:34 apollo kernel: [<c012d86b>] handle_IRQ_event+0x1a/0x3f
>> Jun 16 23:22:34 apollo kernel: [<c0241193>] velocity_free_rd_ring+0xa5/0xb6
>> Jun 16 23:22:34 apollo kernel: [<c0144752>] kfree+0x6a/0x72
>> Jun 16 23:22:34 apollo kernel: [<c0241193>] velocity_free_rd_ring+0xa5/0xb6
>> Jun 16 23:22:34 apollo kernel: [<c0105816>] dma_free_coherent+0x3a/0x9c
>> Jun 16 23:22:34 apollo kernel: [<c02411eb>]
>> velocity_free_dma_rings+0x47/0x4d
>> Jun 16 23:22:34 apollo kernel: [<c024225b>] velocity_change_mtu+0xf6/0x157
>> Jun 16 23:22:34 apollo kernel: [<c02856c4>] dev_set_mtu+0x2a/0x4f
>> Jun 16 23:22:34 apollo kernel: [<c0286642>] dev_ioctl+0x4ab/0x530
>> Jun 16 23:22:34 apollo kernel: [<c012e4cb>] handle_fasteoi_irq+0x74/0x77
>> Jun 16 23:22:34 apollo kernel: [<c010479b>] do_IRQ+0x50/0x60
>> Jun 16 23:22:34 apollo kernel: [<c027d785>] sock_ioctl+0x0/0x177
>>
>
> Does the patch below make a difference ?
>
> diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
> index 71a5133..fa303da 100644
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -1274,7 +1274,7 @@ static void velocity_free_rd_ring(struct velocity_info *vptr)
> PCI_DMA_FROMDEVICE);
> rd_info->skb_dma = (dma_addr_t) NULL;
>
> - dev_kfree_skb(rd_info->skb);
> + dev_kfree_skb_any(rd_info->skb);
> rd_info->skb = NULL;
> }
>
> @@ -1336,7 +1336,7 @@ static void velocity_free_td_ring_entry(struct velocity_info *vptr,
> td_info->skb_dma[i] = (dma_addr_t) NULL;
> }
> }
> - dev_kfree_skb(td_info->skb);
> + dev_kfree_skb_any(td_info->skb);
> td_info->skb = NULL;
> }
> }
>
Idem.
Jun 18 01:30:15 apollo kernel: ------------[ cut here ]------------
Jun 18 01:30:15 apollo kernel: WARNING: at arch/x86/kernel/pci-dma.c:482
dma_free_coherent+0x3a/0x9c()
Jun 18 01:30:15 apollo kernel: Pid: 1401, comm: ip Not tainted
2.6.26-rc6EPIA_SN_VB7001 #4
Jun 18 01:30:15 apollo kernel: [<c0115fe5>] warn_on_slowpath+0x3b/0x5f
Jun 18 01:30:15 apollo kernel: [<c0133b19>]
__alloc_pages_internal+0xb4/0x349
Jun 18 01:30:15 apollo kernel: [<c0112bfd>] hrtick_start_fair+0x67/0xfd
Jun 18 01:30:15 apollo kernel: [<c011414f>] check_preempt_wakeup+0x9d/0xbb
Jun 18 01:30:15 apollo kernel: [<c0144752>] kfree+0x6a/0x72
Jun 18 01:30:15 apollo kernel: [<c0241193>] velocity_free_rd_ring+0xa5/0xb6
Jun 18 01:30:15 apollo kernel: [<c0105816>] dma_free_coherent+0x3a/0x9c
Jun 18 01:30:15 apollo kernel: [<c02411eb>]
velocity_free_dma_rings+0x47/0x4d
Jun 18 01:30:15 apollo kernel: [<c024225b>] velocity_change_mtu+0xf6/0x157
Jun 18 01:30:15 apollo kernel: [<c02856c4>] dev_set_mtu+0x2a/0x4f
Jun 18 01:30:15 apollo kernel: [<c0286642>] dev_ioctl+0x4ab/0x530
Jun 18 01:30:15 apollo kernel: [<c013964a>] __do_fault+0x256/0x28e
Jun 18 01:30:15 apollo kernel: [<c027d8d7>] sock_ioctl+0x152/0x177
Jun 18 01:30:15 apollo kernel: [<c027d785>] sock_ioctl+0x0/0x177
Jun 18 01:30:15 apollo kernel: [<c0150b4a>] vfs_ioctl+0x16/0x48
Jun 18 01:30:15 apollo kernel: [<c0150d5a>] do_vfs_ioctl+0x1de/0x1f1
Jun 18 01:30:15 apollo kernel: [<c0150dae>] sys_ioctl+0x41/0x5b
Jun 18 01:30:15 apollo kernel: [<c010291d>] sysenter_past_esp+0x6a/0x91
Jun 18 01:30:15 apollo kernel: =======================
Jun 18 01:30:15 apollo kernel: ---[ end trace abc2c54f7fac91dc ]---
--
Régis
next prev parent reply other threads:[~2008-06-17 23:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 1:46 [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change Arjan van de Ven
2008-06-03 20:40 ` Andrew Morton
2008-06-03 21:51 ` Francois Romieu
2008-06-04 21:59 ` Francois Romieu
2008-06-14 21:23 ` Francois Romieu
2008-06-16 17:21 ` Séguier Régis
2008-06-16 21:17 ` Séguier Régis
2008-06-16 21:25 ` Séguier Régis
2008-06-17 21:45 ` Francois Romieu
2008-06-17 23:37 ` Séguier Régis [this message]
2008-06-18 16:56 ` Séguier Régis
2008-06-18 20:10 ` Francois Romieu
2008-06-18 22:09 ` Séguier Régis
2008-06-19 20:43 ` Francois Romieu
2008-06-20 10:24 ` Séguier Régis
2008-06-20 10:39 ` Francois Romieu
2008-06-20 16:50 ` Séguier Régis
2008-06-23 17:04 ` Séguier Régis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48584AA4.8040801@e-teleport.net \
--to=rseguier@e-teleport.net \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).