From: Jeff Garzik <jeff@garzik.org>
To: David Brownell <david-b@pacbell.net>
Cc: netdev@vger.kernel.org,
Claudio Lanconelli <lanconelli.claudio@eptar.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND #3/patch 2.6.26-rc6] net/enc28j60: low power mode
Date: Tue, 17 Jun 2008 23:26:27 -0400 [thread overview]
Message-ID: <48588063.4020304@garzik.org> (raw)
In-Reply-To: <200806122138.06674.david-b@pacbell.net>
David Brownell wrote:
> Keep enc28j60 chips in low-power mode when they're not in use.
> At typically 120 mA, these chips run hot even when idle; this
> low power mode cuts that power usage by a factor of around 100.
>
> This version provides a generic routine to poll a register until
> its masked value equals some value ... e.g. bit set or cleared.
> It's basically what the previous wait_phy_ready() did, but this
> version is generalized to support the handshaking needed to
> enter and exit low power mode.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Signed-off-by: Claudio Lanconelli <lanconelli.claudio@eptar.com>
> ---
> Previously sent: 18-May, 19-February; there were several
> previous iterations too ...
>
> drivers/net/enc28j60.c | 82 ++++++++++++++++++++++++++++++++++---------------
> 1 file changed, 58 insertions(+), 24 deletions(-)
applied
prev parent reply other threads:[~2008-06-18 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 4:38 [RESEND #3/patch 2.6.26-rc6] net/enc28j60: low power mode David Brownell
2008-06-13 9:40 ` Jeff Garzik
2008-06-13 18:21 ` David Brownell
2008-06-18 3:26 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48588063.4020304@garzik.org \
--to=jeff@garzik.org \
--cc=david-b@pacbell.net \
--cc=lanconelli.claudio@eptar.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).