From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?S=E9guier_R=E9gis?= <rseguier@e-teleport.net>
Subject: Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during
 MTU change
Date: Thu, 19 Jun 2008 00:09:08 +0200
Message-ID: <48598784.40306@e-teleport.net>
References: <20080531184615.350bac00@infradead.org> <20080603134019.df2f51d4.akpm@linux-foundation.org> <20080603215155.GA9712@electric-eye.fr.zoreil.com> <20080604215909.GA17446@electric-eye.fr.zoreil.com> <20080614212341.GA12976@electric-eye.fr.zoreil.com> <4856DA62.7080803@e-teleport.net> <20080617214538.GA6388@electric-eye.fr.zoreil.com> <48584AA4.8040801@e-teleport.net> <48593E35.1010409@e-teleport.net> <20080618201012.GA4019@electric-eye.fr.zoreil.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Arjan van de Ven <arjan@infradead.org>, alan@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: Francois Romieu <romieu@fr.zoreil.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from webmail.e-teleport.net ([213.190.83.68]:57163 "EHLO
	mail.imsnet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754145AbYFRWJQ (ORCPT <rfc822;netdev@vger.kernel.org>);
	Wed, 18 Jun 2008 18:09:16 -0400
In-Reply-To: <20080618201012.GA4019@electric-eye.fr.zoreil.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

=46rancois Romieu a =E9crit :
> S=E9guier R=E9gis <rseguier@e-teleport.net> :
> [...]
>  =20
>> This correction seems to work.
>>
>> I read somewhere pci_free_consistent (in velocity_free_dma_rings) co=
uldn't=20
>> be use in a spin_lock.
>>    =20
>
> Yup.
>
>  =20
>> When I move velocity_free_rings outside the spin_lock, error desappe=
are but=20
>> data transfert doesn't work after the mtu change.
>> When I add velocity_give_many_rx_descs all work.
>>    =20
>
> I have updated http://userweb.kernel.org/~romieu/via-velocity/2.6.26-=
rc6/
> accordingly. Can you check whether it is fine or not ?
>
>  =20
Patch 0001 doesn't work,

if I don't make a mistake skb->len is not modified in skb_pad{,to}when=20
the padding is applied. In this case, we need to attribute ETH_ZLEN to =
len.

--=20
R=E9gis