netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>,
	auke-jan.h.kok@intel.com, "Kirsher,
	Jeffrey T" <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH 0/3] e1000,e1000e,igb: make ioport free for adapters that need NO ioport resources
Date: Sat, 21 Jun 2008 11:19:28 -0700	[thread overview]
Message-ID: <485D4630.1090007@intel.com> (raw)
In-Reply-To: <485B1B8E.1060108@jp.fujitsu.com>

Taku Izumi wrote:
> Hi all,
> 
> Only a few Intel Gigabit Adapters need ioport resources for workaround,
> but most do not need them. Most adapters work properly without them.
> In the case where ioport resources are not assigned to adapters, this can
> happen on the large system, drivers' probe function fails like the following,
> and adapters can not be used as a result.
> 
>  e1000e 0002:22:00.0: device not available because of BAR 2 [0:1f] collisions
>  e1000e: probe of 0002:22:00.0 failed with error -22
> 
> These patches corrects behavior in probe function so as not to request ioport
> resources as long as they are not really needed. These are based on the
> ioport-free patch of e1000 driver from Auke Kok and Tomohiro Kusumi.
> 
> * [PATCH 1/3] e1000: make ioport free
> * [PATCH 2/3] e1000e: make ioport free
> * [PATCH 3/3] igb: make ioport free

I think patch 2 and 3 are way too large since igb and e1000e can be totally ioport
free at all times. There is no need to keep compatibility code for ioport in those
drivers as it's unlikely that this will ever be needed.

So, perhaps you can remove the ioport code from those 2 drivers (e1000e/igb)
completely and resubmit to Jeff Kirsher?

Cheers,

Auke

  parent reply	other threads:[~2008-06-21 18:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20  2:53 [PATCH 0/3] e1000,e1000e,igb: make ioport free for adapters that need NO ioport resources Taku Izumi
2008-06-20  2:55 ` [PATCH 1/3] e1000: make ioport free Taku Izumi
2008-06-27  6:08   ` Jeff Garzik
2008-06-27 12:24     ` Taku Izumi
2008-06-27 13:05       ` Taku Izumi
2008-06-27 17:08         ` Jeff Kirsher
2008-06-20  2:57 ` [PATCH 2/3] e1000e: " Taku Izumi
2008-06-23  8:32   ` Taku Izumi
2008-06-27  6:08   ` Jeff Garzik
2008-06-20  3:10 ` [PATCH 3/3] igb: " Taku Izumi
2008-06-23  8:32   ` Taku Izumi
2008-06-21 18:19 ` Kok, Auke [this message]
2008-06-23  8:28   ` [PATCH 0/3] e1000,e1000e,igb: make ioport free for adapters that need NO ioport resources Taku Izumi
2008-06-23 23:40     ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485D4630.1090007@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=kusumi.tomohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).