From: Daniel Lezcano <dlezcano@fr.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: kaber@trash.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, den@openvz.org,
xemul@openvz.org, ebiederm@xmission.com, benjamin.thery@bull.net
Subject: Re: [PATCH 00/25] Conntracking and NAT in netns
Date: Sun, 22 Jun 2008 23:41:56 +0200 [thread overview]
Message-ID: <485EC724.1030005@fr.ibm.com> (raw)
In-Reply-To: <20080622005916.GA5392@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> Hi, patchbomb below makes significant parts of connection tracking and
> NAT code usable in netns and independent from other netns.
>
> Status is that it is lightly tested but more or less works, I used it on
> a box which provides NAT for another with all netdevices moved to netns,
> routing and iptables rules set up and rules flushed in init_net.
>
> So far so good.
>
> Weak points:
> a) races during netns destruction or conntrack modules unload
> (see more in patches)
> b) grabbing netns from skb->dev or skb->dst->dev
> these places should be checked with extreme scrunity :-\
> c) some stuff not converted (pptp, h323) -- it's like 10 minutes to make
> a patch and full day to setup and test it :^)
> d) IPv6 conntracking wasn't tested.
> e) ordering probably should be redone (or it shouldn't since netfilter
> is banned in netns as is, so nobody will care)
You describe this patchset as no finished and there is a patch to not be
applied, shall I assume it is a RFC ?
In any case, thanks Alexey for this patchset, I will it review tomorrow.
-- Daniel
next prev parent reply other threads:[~2008-06-22 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 0:59 [PATCH 00/25] Conntracking and NAT in netns Alexey Dobriyan
2008-06-22 21:41 ` Daniel Lezcano [this message]
2008-06-22 21:54 ` Alexey Dobriyan
2008-06-23 9:57 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485EC724.1030005@fr.ibm.com \
--to=dlezcano@fr.ibm.com \
--cc=adobriyan@gmail.com \
--cc=benjamin.thery@bull.net \
--cc=den@openvz.org \
--cc=ebiederm@xmission.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).