From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
den@openvz.org, xemul@openvz.org, ebiederm@xmission.com,
benjamin.thery@bull.net, dlezcano@fr.ibm.com
Subject: Re: [PATCH 04/25] netns ct: point from conntrack to netns
Date: Mon, 23 Jun 2008 12:06:13 +0200 [thread overview]
Message-ID: <485F7595.7030609@trash.net> (raw)
In-Reply-To: <20080622010239.GE5392@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> +static inline struct net *ct_net(const struct nf_conn *ct)
> +{
> +#ifdef CONFIG_NET_NS
> + return ct->ct_net;
> +#else
> + return &init_net;
> +#endif
> +}
For consistency I'd prefer nf_ct_net(). I know this naming scheme
isn't used consistenly currently, but we're moving towards it.
prev parent reply other threads:[~2008-06-23 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 1:02 [PATCH 04/25] netns ct: point from conntrack to netns Alexey Dobriyan
2008-06-23 10:06 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485F7595.7030609@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=benjamin.thery@bull.net \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).