From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
den@openvz.org, xemul@openvz.org, ebiederm@xmission.com,
benjamin.thery@bull.net, dlezcano@fr.ibm.com
Subject: Re: [PATCH 12/25] netns ct: actualy enable in netns
Date: Mon, 23 Jun 2008 12:49:32 +0200 [thread overview]
Message-ID: <485F7FBC.9040302@trash.net> (raw)
In-Reply-To: <20080622011108.GM5392@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> Known to not work/broken:
> 1) event cache -- double free if netns flushes event cache, not netns-ready,
> haven't looked into this.
The event cache also needs to be per namespace, its not allowed to
be flushed it while connection tracking is still active.
> 2) NOTRACK -- amazing circular dependencies and compile breakages if nf_conn
> is embedded into netns_ct.
>
> This is easy excuse, real excuse is from where to grab netns that early.
> and since we wait until untracked refcount drops to zero it should be per-netns
> otherwise one netns which uses NOTRACK can prevent other from stopping.
Yes. For untracked connections we usually return before doing
any real work, so maybe you don't need a valid netns pointer
for the untrack conntrack entry?
prev parent reply other threads:[~2008-06-23 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 1:11 [PATCH 12/25] netns ct: actualy enable in netns Alexey Dobriyan
2008-06-23 10:49 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485F7FBC.9040302@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=benjamin.thery@bull.net \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).