From: Jeff Garzik <jeff@garzik.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [RESEND PATCH 1/3] e1000e: set CONFIG_E1000E=y in x86 defconfigs
Date: Mon, 23 Jun 2008 19:20:08 -0400 [thread overview]
Message-ID: <48602FA8.7090508@garzik.org> (raw)
In-Reply-To: <20080623112618.GC7485@elte.hu>
Ingo Molnar wrote:
> * Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
>
>> From: Auke Kok <auke-jan.h.kok@intel.com>
>>
>> This adds to the already default CONFIG_E1000=y in these files.
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> ---
>>
>> arch/x86/configs/i386_defconfig | 1 +
>> arch/x86/configs/x86_64_defconfig | 1 +
>
> that is not an e1000 patch but an arch/x86 defconfig patch. NAK on this
> route of patch propagation.
But it's dependent on an e1000 patch. Maybe we could follow the lead of
ppc and other arch maintainers, and work together?
Typically if there are arch dependencies and little drivers/net changes,
I'll ACK the drivers/net change and then let it go through the arch tree.
In this case, there is far more drivers/net code, so it would make the
most sense to work with you to change the defconfigs to your liking, and
then merge them via netdev when the other E1000 changes go in.
Jeff
next prev parent reply other threads:[~2008-06-23 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 22:20 [RESEND PATCH 1/3] e1000e: set CONFIG_E1000E=y in x86 defconfigs Jeff Kirsher
2008-06-22 22:21 ` [RESEND PATCH 2/3] e1000: remove PCI Express device IDs Jeff Kirsher
2008-06-27 6:08 ` Jeff Garzik
2008-06-22 22:22 ` [RESEND PATCH 3/3] e1000: enable NAPI by default in defconfig Jeff Kirsher
2008-06-23 11:26 ` [RESEND PATCH 1/3] e1000e: set CONFIG_E1000E=y in x86 defconfigs Ingo Molnar
2008-06-23 23:14 ` Jeff Kirsher
2008-06-23 23:20 ` Jeff Garzik [this message]
2008-06-26 12:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48602FA8.7090508@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).