From: Max Krasnyansky <maxk@qualcomm.com>
To: David Miller <davem@davemloft.net>
Cc: wcang@nav6.org, steve.zabele@baesystems.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NET: Proper handling of IPv6 header in tun driver when TUN_NO_PI is set
Date: Mon, 23 Jun 2008 22:09:46 -0700 [thread overview]
Message-ID: <4860819A.4030809@qualcomm.com> (raw)
In-Reply-To: <20080617.210803.190930256.davem@davemloft.net>
David Miller wrote:
> From: Ang Way Chuang <wcang@nav6.org>
> Date: Wed, 18 Jun 2008 10:13:31 +0800
>
>> David Miller wrote:
>>> From: Max Krasnyanskiy <maxk@qualcomm.com>
>>> Date: Fri, 06 Jun 2008 13:21:06 -0700
>>>
>>>> Acked-by: Max Krasnyansky <maxk@qualcomm.com>
>>>>
>>>> Dave, can you please add this patch to your tree.
>>> I can't, the patch is severely whitespace damaged.
>>>
>> Resend. Hopefully Thunderbird won't screw this time.
>
> Same problem, tabs were transformed into spaces, and
> lines composed of only whitespace were transformed into
> empty lines.
>
> This is frustrating enough, I'm just going to fix this up
> by hand for you, but please get your shit straight for next
> time because I won't do this twice.
Dave, thanks a lot for fixing this up. I looked at the patch and logic wise it
looked perfectly fine. I did not notice the problem with the spaces. Sorry.
Max
next prev parent reply other threads:[~2008-06-24 5:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 10:49 [PATCH] NET: Proper handling of IPv6 header in tun driver when TUN_NO_PI is set Ang Way Chuang
2008-06-06 20:21 ` Max Krasnyanskiy
2008-06-06 20:48 ` Stephen Hemminger
2008-06-06 20:55 ` [PATCH] NET: Proper handling of IPv6 header in tun driver whenTUN_NO_PI " Zabele, Stephen (US SSA)
2008-06-17 23:32 ` [PATCH] NET: Proper handling of IPv6 header in tun driver when TUN_NO_PI " David Miller
2008-06-18 2:13 ` Ang Way Chuang
2008-06-18 4:08 ` David Miller
2008-06-24 5:09 ` Max Krasnyansky [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-06 12:13 wcang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4860819A.4030809@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.zabele@baesystems.com \
--cc=wcang@nav6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).