Re: RFC: Patch to add support for multiple multicast routing tables.

[Ben Greear <greearb@candelatech.com>]

Stephen Hemminger wrote:
> On Tue, 24 Jun 2008 17:50:51 -0700
> Ben Greear <greearb@candelatech.com> wrote:
>
>   
>> In order to run multiple Xorp instances and treat different groups of
>> interfaces as being in their own virtual router, I had to update the
>> ipv4/ipmr.c logic to support multiple routing tables.
>>
>> I will be attempting to push the cooresponding xorp changes to it's
>> maintainers if this is accepted into the kernel.  It should be fully
>> backwards compatible with existing xorp and other multicast
>> routing tools.  It does change the procfs output slightly, adding
>> a TableId column.
>>
>> The original patch was written by me, and then Patrick McHardy
>> fixed up my cruft and made it much smaller and with better locking.
>> I then fixed a few bugs I found while testing with my modified xorp.
>>
>> The attached patch is against 2.6.25.4 + hacks.  It has a few rejects 
>> against 2.6.26.rc7,
>> but I will fix those sooner rather than later if the patch is otherwise 
>> deemed
>> worthy.
>>
>> Please let me know if this stands a chance of inclusion.
>>
>> Thanks,
>> Ben
>>     
>
> Ben private ioctl's make it hard to handle 32bit/64bit compatiablity,
> and routing is better managed through rtnetlink. Doesn't XORP do
> netlink?
>   
It seemed the path of least resistance, less the patch become even larger.

Xorp does use netlink, but not for multicast (or, at least, not for the 
part of
multicast that talks to ipv4/ipmr.c).  The patch to xorp to support 
multiple routing tables is
not too large, and is backwards compat with older kernels (and bsd-ish 
systems
I suppose.)

For 32/64 compat, how about we make the structs passed in 'attribute 
packed' ?

We can also make the table-id 'u32' or similar to guarantee the size of the
member.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com> 
Candela Technologies Inc  http://www.candelatech.com