From: Anthony Liguori <anthony@codemonkey.ws>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
markmc@redhat.com, netdev@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 4/4] lguest: Use GSO/IFF_VNET_HDR extensions on tun/tap
Date: Wed, 25 Jun 2008 14:07:18 -0500 [thread overview]
Message-ID: <48629766.4040905@codemonkey.ws> (raw)
In-Reply-To: <200806260032.12359.rusty__46755.7742762894$1214404667$gmane$org@rustcorp.com.au>
Rusty Russell wrote:
> @@ -1563,6 +1561,16 @@ static void setup_tun_net(char *arg)
> /* Tell Guest what MAC address to use. */
> add_feature(dev, VIRTIO_NET_F_MAC);
> add_feature(dev, VIRTIO_F_NOTIFY_ON_EMPTY);
> + /* Expect Guest to handle everything except UFO */
> + add_feature(dev, VIRTIO_NET_F_CSUM);
You're setting this feature twice.
> + add_feature(dev, VIRTIO_NET_F_GUEST_CSUM);
You set this feature, but I never see the virtio-net driver acknowledge
the feature. Curiously, my implementation with KVM is struggling
because UDP packet checksums are not correct so the DHCP client is
ignoring them. If I disable CSUM offload, things it works fine (using
the virtio-net header). The problem is only host=>guest, guest=>host is
fine.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-06-25 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 14:28 [PATCH 1/4] tun: Interface to query tun/tap features Rusty Russell
2008-06-25 14:29 ` [PATCH 2/4] tun: TUNSETFEATURES to set gso features Rusty Russell
2008-06-25 14:30 ` [PATCH 3/4] tun: Allow GSO using virtio_net_hdr Rusty Russell
2008-06-25 14:32 ` [PATCH 4/4] lguest: Use GSO/IFF_VNET_HDR extensions on tun/tap Rusty Russell
2008-06-25 15:45 ` Rusty Russell
[not found] ` <200806260032.12359.rusty__46755.7742762894$1214404667$gmane$org@rustcorp.com.au>
2008-06-25 19:07 ` Anthony Liguori [this message]
2008-06-26 4:40 ` Rusty Russell
2008-06-26 18:16 ` Anthony Liguori
2008-06-27 3:50 ` Rusty Russell
2008-07-02 5:25 ` Max Krasnyansky
2008-07-02 5:13 ` [PATCH 3/4] tun: Allow GSO using virtio_net_hdr Max Krasnyansky
2008-07-02 7:00 ` Rusty Russell
2008-07-24 14:20 ` Herbert Xu
2008-07-24 23:54 ` Rusty Russell
2008-07-02 5:02 ` [PATCH 2/4] tun: TUNSETFEATURES to set gso features Max Krasnyansky
2008-07-02 4:59 ` [PATCH 1/4] tun: Interface to query tun/tap features Max Krasnyansky
2008-07-02 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48629766.4040905@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=herbert@gondor.apana.org.au \
--cc=markmc@redhat.com \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).