netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: netdev@vger.kernel.org, ram.vepa@neterion.com,
	santosh.rastapur@neterion.com, sivakumar.subramani@neterion.com,
	sreenivasa.honnur@neterion.com
Subject: Re: [PATCH] Fix IOMMU overflow checking in s2io.c
Date: Fri, 27 Jun 2008 01:32:36 -0400	[thread overview]
Message-ID: <48647B74.8020207@garzik.org> (raw)
In-Reply-To: <20080618115836.GA18655@basil.nowhere.org>

Andi Kleen wrote:
> Fix IOMMU overflow checking in s2io.c
> 
> s2io has IOMMU overflow checking, but unfortunately it is wrong.
> 
> It didn't use the standard macros, which meant that it only worked
> on POWER and SPARC because only those define DMA_ERROR_CODE. Convert it to 
> use the standard macros instead.
> 
> I also commented two more bugs in the IOMMU handling. It assumes
> that 0 DMA addresses cannot happen, but that's not true in all IOMMU setups.
> The information if a buffer has been already mapped needs to be stored
> elsewhere.
> 
> Didn't fix those because it needs careful checking of the buffer handling
> by the maintainers.
> 
> Cc: ram.vepa@neterion.com
> Cc: santosh.rastapur@neterion.com
> Cc: sivakumar.subramani@neterion.com
> Cc: sreenivasa.honnur@neterion.com
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

applied



      parent reply	other threads:[~2008-06-27  5:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 11:58 [PATCH] Fix IOMMU overflow checking in s2io.c Andi Kleen
2008-06-26  2:16 ` Ramkrishna Vepa
2008-06-27  5:32 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48647B74.8020207@garzik.org \
    --to=jeff@garzik.org \
    --cc=andi@firstfloor.org \
    --cc=netdev@vger.kernel.org \
    --cc=ram.vepa@neterion.com \
    --cc=santosh.rastapur@neterion.com \
    --cc=sivakumar.subramani@neterion.com \
    --cc=sreenivasa.honnur@neterion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).