From: Jeff Garzik <jeff@garzik.org>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com
Subject: Re: [PATCH 3/4] e1000: only enable TSO6 via ethtool when using correct hardware
Date: Fri, 27 Jun 2008 01:32:43 -0400 [thread overview]
Message-ID: <48647B7B.3030805@garzik.org> (raw)
In-Reply-To: <20080619211902.GE22981@gospo.rdu.redhat.com>
Andy Gospodarek wrote:
> When enabling TSO via ethool on e1000, it is possible to set
> NETIF_F_TSO6 on hardware that does not support it. Setting TSO via
> ethtool now matches the settings used when the hardware is probed.
>
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> ---
> drivers/net/e1000/e1000_ethtool.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c
> index 701531e..a3f6a9c 100644
> --- a/drivers/net/e1000/e1000_ethtool.c
> +++ b/drivers/net/e1000/e1000_ethtool.c
> @@ -347,7 +347,7 @@ e1000_set_tso(struct net_device *netdev, u32 data)
> else
> netdev->features &= ~NETIF_F_TSO;
>
> - if (data)
> + if (data && (adapter->hw.mac_type > e1000_82547_rev_2))
> netdev->features |= NETIF_F_TSO6;
applied
prev parent reply other threads:[~2008-06-27 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 21:19 [PATCH 3/4] e1000: only enable TSO6 via ethtool when using correct hardware Andy Gospodarek
2008-06-27 5:32 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48647B7B.3030805@garzik.org \
--to=jeff@garzik.org \
--cc=andy@greyhouse.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).