From: Jeff Garzik <jeff@garzik.org>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: romieu@fr.zoreil.com, sorbica@icplus.com.tw, jesse@icplus.com.tw,
Bircoph@list.ru, shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH 02/08] ipg: use NULL, not zero, for pointers
Date: Fri, 27 Jun 2008 01:33:19 -0400 [thread overview]
Message-ID: <48647B9F.1070604@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0806231434300.23716@sbz-30.cs.Helsinki.FI>
Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> Fixes a sparse warning in a code block that's hidden under JUMBO_FRAME #ifdef.
>
> Tested-by: Andrew Savchenko <Bircoph@list.ru>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> drivers/net/ipg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/net/ipg.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/ipg.c
> +++ linux-2.6/drivers/net/ipg.c
> @@ -1808,7 +1808,7 @@ static int ipg_nic_open(struct net_devic
> /* initialize JUMBO Frame control variable */
> sp->jumbo.found_start = 0;
> sp->jumbo.current_size = 0;
> - sp->jumbo.skb = 0;
> + sp->jumbo.skb = NULL;
> dev->mtu = IPG_TXFRAG_SIZE;
> #endif
applied 1-2 to 2.6.26
prev parent reply other threads:[~2008-06-27 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 11:34 [PATCH 02/08] ipg: use NULL, not zero, for pointers Pekka J Enberg
2008-06-27 5:33 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48647B9F.1070604@garzik.org \
--to=jeff@garzik.org \
--cc=Bircoph@list.ru \
--cc=jesse@icplus.com.tw \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@vyatta.com \
--cc=sorbica@icplus.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).