From: Jeff Garzik <jgarzik@pobox.com>
To: Julia Lawall <julia@diku.dk>
Cc: florian.fainelli@telecomint.eu, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/net/r6040.c: Eliminate double sizeof
Date: Fri, 27 Jun 2008 01:33:30 -0400 [thread overview]
Message-ID: <48647BAA.8060308@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0806232311570.13402@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Taking sizeof the result of sizeof is quite strange and does not seem to be
> what is wanted here.
>
> This was fixed using the following semantic patch.
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression E;
> @@
>
> - sizeof (
> sizeof (E)
> - )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
applied
prev parent reply other threads:[~2008-06-27 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 21:12 [PATCH] drivers/net/r6040.c: Eliminate double sizeof Julia Lawall
2008-06-24 8:54 ` Florian Fainelli
2008-06-27 5:33 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48647BAA.8060308@pobox.com \
--to=jgarzik@pobox.com \
--cc=florian.fainelli@telecomint.eu \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).