From: Jeff Garzik <jeff@garzik.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow
Date: Fri, 27 Jun 2008 01:33:56 -0400 [thread overview]
Message-ID: <48647BC4.90402@garzik.org> (raw)
In-Reply-To: <20080626.171415.81099548.nemoto@toshiba-tops.co.jp>
Atsushi Nemoto wrote:
> On Rx FIFO overflow error, the controller consume a buffer descriptor
> but currently the driver does not give it back to the controller.
> This results unrecoverable 'Buffer List Exhausted' condition. This
> patch fix this problem by moving a "fbl_count--" line to proper place.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index dccea52..b07b8cb 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -1736,7 +1736,6 @@ tc35815_rx(struct net_device *dev)
> skb = lp->rx_skbs[cur_bd].skb;
> prefetch(skb->data);
> lp->rx_skbs[cur_bd].skb = NULL;
> - lp->fbl_count--;
> pci_unmap_single(lp->pci_dev,
> lp->rx_skbs[cur_bd].skb_dma,
> RX_BUF_SIZE, PCI_DMA_FROMDEVICE);
> @@ -1792,6 +1791,7 @@ tc35815_rx(struct net_device *dev)
> #ifdef TC35815_USE_PACKEDBUFFER
> while (lp->fbl_curid != id)
> #else
> + lp->fbl_count--;
> while (lp->fbl_count < RX_BUF_NUM)
> #endif
> {
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
applied
prev parent reply other threads:[~2008-06-27 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 8:14 [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow Atsushi Nemoto
2008-06-27 5:33 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48647BC4.90402@garzik.org \
--to=jeff@garzik.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).