* [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow
@ 2008-06-26 8:14 Atsushi Nemoto
2008-06-27 5:33 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2008-06-26 8:14 UTC (permalink / raw)
To: linux-mips; +Cc: Jeff Garzik, netdev
On Rx FIFO overflow error, the controller consume a buffer descriptor
but currently the driver does not give it back to the controller.
This results unrecoverable 'Buffer List Exhausted' condition. This
patch fix this problem by moving a "fbl_count--" line to proper place.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index dccea52..b07b8cb 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -1736,7 +1736,6 @@ tc35815_rx(struct net_device *dev)
skb = lp->rx_skbs[cur_bd].skb;
prefetch(skb->data);
lp->rx_skbs[cur_bd].skb = NULL;
- lp->fbl_count--;
pci_unmap_single(lp->pci_dev,
lp->rx_skbs[cur_bd].skb_dma,
RX_BUF_SIZE, PCI_DMA_FROMDEVICE);
@@ -1792,6 +1791,7 @@ tc35815_rx(struct net_device *dev)
#ifdef TC35815_USE_PACKEDBUFFER
while (lp->fbl_curid != id)
#else
+ lp->fbl_count--;
while (lp->fbl_count < RX_BUF_NUM)
#endif
{
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow
2008-06-26 8:14 [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow Atsushi Nemoto
@ 2008-06-27 5:33 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-06-27 5:33 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, netdev
Atsushi Nemoto wrote:
> On Rx FIFO overflow error, the controller consume a buffer descriptor
> but currently the driver does not give it back to the controller.
> This results unrecoverable 'Buffer List Exhausted' condition. This
> patch fix this problem by moving a "fbl_count--" line to proper place.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index dccea52..b07b8cb 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -1736,7 +1736,6 @@ tc35815_rx(struct net_device *dev)
> skb = lp->rx_skbs[cur_bd].skb;
> prefetch(skb->data);
> lp->rx_skbs[cur_bd].skb = NULL;
> - lp->fbl_count--;
> pci_unmap_single(lp->pci_dev,
> lp->rx_skbs[cur_bd].skb_dma,
> RX_BUF_SIZE, PCI_DMA_FROMDEVICE);
> @@ -1792,6 +1791,7 @@ tc35815_rx(struct net_device *dev)
> #ifdef TC35815_USE_PACKEDBUFFER
> while (lp->fbl_curid != id)
> #else
> + lp->fbl_count--;
> while (lp->fbl_count < RX_BUF_NUM)
> #endif
> {
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-27 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-26 8:14 [PATCH] tc35815: Fix receiver hangup on Rx FIFO overflow Atsushi Nemoto
2008-06-27 5:33 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).