* [PATCH] tc35815: Mark carrier-off before starting PHY
@ 2008-06-25 2:41 Atsushi Nemoto
2008-06-27 5:34 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Nemoto @ 2008-06-25 2:41 UTC (permalink / raw)
To: linux-mips; +Cc: Jeff Garzik, netdev
Call netif_carrier_off() before starting PHY device. This is a
behavior before converting to generic PHY layer.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
index 10e4e85..dccea52 100644
--- a/drivers/net/tc35815.c
+++ b/drivers/net/tc35815.c
@@ -1394,6 +1394,7 @@ tc35815_open(struct net_device *dev)
tc35815_chip_init(dev);
spin_unlock_irq(&lp->lock);
+ netif_carrier_off(dev);
/* schedule a link state check */
phy_start(lp->phy_dev);
@@ -2453,6 +2454,7 @@ static int tc35815_resume(struct pci_dev *pdev)
return 0;
pci_set_power_state(pdev, PCI_D0);
tc35815_restart(dev);
+ netif_carrier_off(dev);
if (lp->phy_dev)
phy_start(lp->phy_dev);
netif_device_attach(dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tc35815: Mark carrier-off before starting PHY
2008-06-25 2:41 [PATCH] tc35815: Mark carrier-off before starting PHY Atsushi Nemoto
@ 2008-06-27 5:34 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-06-27 5:34 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips, netdev
Atsushi Nemoto wrote:
> Call netif_carrier_off() before starting PHY device. This is a
> behavior before converting to generic PHY layer.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index 10e4e85..dccea52 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -1394,6 +1394,7 @@ tc35815_open(struct net_device *dev)
> tc35815_chip_init(dev);
> spin_unlock_irq(&lp->lock);
>
> + netif_carrier_off(dev);
> /* schedule a link state check */
> phy_start(lp->phy_dev);
>
> @@ -2453,6 +2454,7 @@ static int tc35815_resume(struct pci_dev *pdev)
> return 0;
> pci_set_power_state(pdev, PCI_D0);
> tc35815_restart(dev);
> + netif_carrier_off(dev);
> if (lp->phy_dev)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-27 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-25 2:41 [PATCH] tc35815: Mark carrier-off before starting PHY Atsushi Nemoto
2008-06-27 5:34 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).