[PATCH] s2io: fix documentation about intr_type

[PATCH] s2io: fix documentation about intr_type

[Michal Schmidt]

The documentation for intr_type module parameter of the s2io driver is
not consistent with the code. The comments in drivers/net/s2io.c are
OK, but Documentation/networking/s2io.txt is wrong.

Pointed out by Andrew Hecox.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>

---
 Documentation/networking/s2io.txt |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/networking/s2io.txt b/Documentation/networking/s2io.txt
index 4bde53e..1e28e2d 100644
--- a/Documentation/networking/s2io.txt
+++ b/Documentation/networking/s2io.txt
@@ -83,9 +83,9 @@ Valid range: Limited by memory on system
 Default: 30 
 
 e. intr_type
-Specifies interrupt type. Possible values 1(INTA), 2(MSI), 3(MSI-X)
-Valid range: 1-3
-Default: 1 
+Specifies interrupt type. Possible values 0(INTA), 2(MSI-X)
+Valid values: 0, 2
+Default: 2
 
 5.  Performance suggestions
 General:
-- 
1.5.5.1

RE: [PATCH] s2io: fix documentation about intr_type

[Ramkrishna Vepa]

Michal,
Thanks for the fix. 

Jeff,
Please accept the patch.

Thanks,
Ram

> -----Original Message-----
> From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org]
> On Behalf Of Michal Schmidt
> Sent: Thursday, June 26, 2008 7:06 AM
> To: Jeff Garzik
> Cc: netdev@vger.kernel.org; Sreenivasa Honnur
> Subject: [PATCH] s2io: fix documentation about intr_type
> 
> The documentation for intr_type module parameter of the s2io driver is
> not consistent with the code. The comments in drivers/net/s2io.c are
> OK, but Documentation/networking/s2io.txt is wrong.
> 
> Pointed out by Andrew Hecox.
> 
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> 
> ---
>  Documentation/networking/s2io.txt |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/s2io.txt
> b/Documentation/networking/s2io.txt
> index 4bde53e..1e28e2d 100644
> --- a/Documentation/networking/s2io.txt
> +++ b/Documentation/networking/s2io.txt
> @@ -83,9 +83,9 @@ Valid range: Limited by memory on system
>  Default: 30
> 
>  e. intr_type
> -Specifies interrupt type. Possible values 1(INTA), 2(MSI), 3(MSI-X)
> -Valid range: 1-3
> -Default: 1
> +Specifies interrupt type. Possible values 0(INTA), 2(MSI-X)
> +Valid values: 0, 2
> +Default: 2
> 
>  5.  Performance suggestions
>  General:
> --
> 1.5.5.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] s2io: fix documentation about intr_type

[Jeff Garzik]

Michal Schmidt wrote:
> The documentation for intr_type module parameter of the s2io driver is
> not consistent with the code. The comments in drivers/net/s2io.c are
> OK, but Documentation/networking/s2io.txt is wrong.
> 
> Pointed out by Andrew Hecox.
> 
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> 
> ---
>  Documentation/networking/s2io.txt |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/s2io.txt b/Documentation/networking/s2io.txt
> index 4bde53e..1e28e2d 100644
> --- a/Documentation/networking/s2io.txt
> +++ b/Documentation/networking/s2io.txt
> @@ -83,9 +83,9 @@ Valid range: Limited by memory on system
>  Default: 30 
>  
>  e. intr_type
> -Specifies interrupt type. Possible values 1(INTA), 2(MSI), 3(MSI-X)
> -Valid range: 1-3
> -Default: 1 
> +Specifies interrupt type. Possible values 0(INTA), 2(MSI-X)
> +Valid values: 0, 2
> +Default: 2

applied