From: Eric Miao <eric.y.miao@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-netdev <netdev@vger.kernel.org>,
Nicolas Pitre <nico@cam.org>, Magnus Damm <magnus.damm@gmail.com>,
Eric Miao <eric.miao@marvell.com>
Subject: Re: [PATCH 01/10] smc91x: remove unused code enclosed by #ifdef CONFIG_ISA .. #endif
Date: Fri, 27 Jun 2008 14:10:47 +0800 [thread overview]
Message-ID: <48648467.1080308@gmail.com> (raw)
In-Reply-To: <486480E6.8070804@garzik.org>
Jeff Garzik wrote:
> Eric Miao wrote:
>> Apparently, the code enclosed by #ifdef CONFIG_ISA .. #endif are no
>> longer
>> used
>
> What does this mean?
>
> CONFIG_ISA platforms still exist, and one presumes that the ISA hardware
> still exists.
>
> Is this hardware covered by another driver?
>
Well, I assume the original code tends to support ISA with module
parameters to setup the IO address base and IRQ etc. But obviously,
those part of the code is now totally invalid and confusing only.
Should there be requirement of supporting ISA hardware with this
chip, the driver is actually unable to, and I prefer to re-write
that part of the code if necessary.
BTW: I don't know any ISA NIC with a SMC91X chip by far, and I
cannot infer by the driver code itself what type of ISA NIC it
is supporting.
next prev parent reply other threads:[~2008-06-27 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-24 9:47 [PATCH 01/10] smc91x: remove unused code enclosed by #ifdef CONFIG_ISA .. #endif Eric Miao
2008-06-26 23:52 ` Nicolas Pitre
2008-06-27 5:55 ` Jeff Garzik
2008-06-27 6:10 ` Eric Miao [this message]
2008-06-27 6:31 ` Jeff Garzik
2008-06-27 13:48 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48648467.1080308@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=eric.miao@marvell.com \
--cc=jeff@garzik.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).