From: Pidoux <f6bvp@free.fr>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ralf@linux-mips.org, linux-hams@vger.kernel.org
Subject: [ROSE] unregister_netdevice: waiting for rose0 to become free
Date: Sun, 29 Jun 2008 21:25:21 +0200 [thread overview]
Message-ID: <4867E1A1.2000702@free.fr> (raw)
In-Reply-To: <20080617.024224.160706790.davem@davemloft.net>
A bug in ROSE protocol is preventing removal of rose module.
After killing all ROSE and AX25 applications, there are no more sockets and
rose usage count is correctly decreased to null as seen in /proc/modules :
rose 40120 0 - Live 0xe1071000
However, issuing command rmmod rose displays the following message in loop forever :
kernel: unregister_netdevice: waiting for rose0 to become free. Usage count = 2
Usage count can be different and seems random (not correlated with module usage count reached when ROSE
applications are loaded).
Tracing the problem shows that above message is sent by core/dev.c
Here is the loop :
while (atomic_read(&dev->refcnt) !=0) {
....
}
Obviously, displayed usage count (dev->refcnt) is not the same as in /proc/modules or given by command
lsmod and also it is not decremented, i.e. it stays at the same, and probably not relevant, value.
A comment in core/dev.c says that buggy protocol don't correctly call dev_put().
I tried to review rose module source but I have not been able to find a correct place where dev_put(dev) could be
missing either in af_rose.c or rose_route.c.
Maybe the problem is elsewhere ?
Bernard Pidoux, f6bvp
next prev parent reply other threads:[~2008-06-29 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 9:42 [PATCH]: Consolidate rose socket grafting David Miller
2008-06-29 19:25 ` Pidoux [this message]
2008-06-30 13:37 ` [ROSE] unregister_netdevice: waiting for rose0 to become free Pidoux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4867E1A1.2000702@free.fr \
--to=f6bvp@free.fr \
--cc=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).