netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Peter Warasin <peter@endian.com>,
	netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [NETFILTER Kconfig help text]: bridge: add ebt_nflog watcher
Date: Mon, 30 Jun 2008 20:21:27 +0200	[thread overview]
Message-ID: <48692427.7090703@trash.net> (raw)
In-Reply-To: <m3bq1i6b41.fsf@maximus.localdomain>

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Krzysztof Halasa wrote:
> is the following really correct?
> e7bfd0a1a6c8f82977253dab19be9d9979c1ec1b
> 
> +	tristate "ebt: nflog support"
> +	depends on BRIDGE_NF_EBTABLES
> +	help
> +	  This option enables the nflog watcher, which allows to LOG
> +	  messages through the netfilter logging API, which can use
> +	  either the old LOG target, the old ULOG target or nfnetlink_log
> +	  as backend.
> +
> +	  This option adds the ulog watcher, that you can use in any rule
>                                ^^^^^^^^^^^^
> 
> ulog watcher?

That appears to be a cut-and-paste error. I've queued this fix.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 877 bytes --]

commit d921ce404ad26e2169e8f89e9a59722ecff35fcf
Author: Patrick McHardy <kaber@trash.net>
Date:   Mon Jun 30 20:21:07 2008 +0200

    netfilter: ebt_nflog: fix Kconfig typo
    
    The help text should refer to nflog instead of ulog. Noticed by
    Krzysztof Halasa <khc@pm.waw.pl>.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index 540df41..9094797 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -230,7 +230,7 @@ config BRIDGE_EBT_NFLOG
 	  either the old LOG target, the old ULOG target or nfnetlink_log
 	  as backend.
 
-	  This option adds the ulog watcher, that you can use in any rule
+	  This option adds the nflog watcher, that you can use in any rule
 	  in any ebtables table.
 
 	  To compile it as a module, choose M here.  If unsure, say N.

  reply	other threads:[~2008-06-30 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 18:17 [NETFILTER Kconfig help text]: bridge: add ebt_nflog watcher Krzysztof Halasa
2008-06-30 18:21 ` Patrick McHardy [this message]
2008-06-30 19:07   ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48692427.7090703@trash.net \
    --to=kaber@trash.net \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter@endian.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).