[NETFILTER Kconfig help text]: bridge: add ebt_nflog watcher

[NETFILTER Kconfig help text]: bridge: add ebt_nflog watcher

[Krzysztof Halasa]

Hi,

is the following really correct?
e7bfd0a1a6c8f82977253dab19be9d9979c1ec1b

------------------------- net/bridge/netfilter/Kconfig -------------------------
index 4a3e2bf..7beeefa 100644
@@ -214,2 +214,16 @@ config BRIDGE_EBT_ULOG
 
+config BRIDGE_EBT_NFLOG
+	tristate "ebt: nflog support"
+	depends on BRIDGE_NF_EBTABLES
+	help
+	  This option enables the nflog watcher, which allows to LOG
+	  messages through the netfilter logging API, which can use
+	  either the old LOG target, the old ULOG target or nfnetlink_log
+	  as backend.
+
+	  This option adds the ulog watcher, that you can use in any rule
                               ^^^^^^^^^^^^
+	  in any ebtables table.
+
+	  To compile it as a module, choose M here.  If unsure, say N.
+
 endmenu


ulog watcher?
-- 
Krzysztof Halasa

Re: [NETFILTER Kconfig help text]: bridge: add ebt_nflog watcher

[Patrick McHardy]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Krzysztof Halasa wrote:
> is the following really correct?
> e7bfd0a1a6c8f82977253dab19be9d9979c1ec1b
> 
> +	tristate "ebt: nflog support"
> +	depends on BRIDGE_NF_EBTABLES
> +	help
> +	  This option enables the nflog watcher, which allows to LOG
> +	  messages through the netfilter logging API, which can use
> +	  either the old LOG target, the old ULOG target or nfnetlink_log
> +	  as backend.
> +
> +	  This option adds the ulog watcher, that you can use in any rule
>                                ^^^^^^^^^^^^
> 
> ulog watcher?

That appears to be a cut-and-paste error. I've queued this fix.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 877 bytes --]

commit d921ce404ad26e2169e8f89e9a59722ecff35fcf
Author: Patrick McHardy <kaber@trash.net>
Date:   Mon Jun 30 20:21:07 2008 +0200

    netfilter: ebt_nflog: fix Kconfig typo
    
    The help text should refer to nflog instead of ulog. Noticed by
    Krzysztof Halasa <khc@pm.waw.pl>.
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index 540df41..9094797 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -230,7 +230,7 @@ config BRIDGE_EBT_NFLOG
 	  either the old LOG target, the old ULOG target or nfnetlink_log
 	  as backend.
 
-	  This option adds the ulog watcher, that you can use in any rule
+	  This option adds the nflog watcher, that you can use in any rule
 	  in any ebtables table.
 
 	  To compile it as a module, choose M here.  If unsure, say N.

Re: [NETFILTER Kconfig help text]: bridge: add ebt_nflog watcher

[Krzysztof Halasa]

Patrick McHardy <kaber@trash.net> writes:

> That appears to be a cut-and-paste error. I've queued this fix.

Great, thanks.
-- 
Krzysztof Halasa