* net: fib_rules: fix error code for unsupported families
@ 2008-06-30 20:21 Patrick McHardy
2008-07-02 3:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2008-06-30 20:21 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 985 bytes --]
commit 92cfe56bb3a0b93db12f84618660fdc0153523eb
Author: Patrick McHardy <kaber@trash.net>
Date: Mon Jun 30 22:19:48 2008 +0200
net: fib_rules: fix error code for unsupported families
The errno code returned must be negative.
Fixes "RTNETLINK answers: Unknown error 18446744073709551519".
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index e3e9ab0..277a230 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -226,7 +226,7 @@ static int fib_nl_newrule(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg)
ops = lookup_rules_ops(net, frh->family);
if (ops == NULL) {
- err = EAFNOSUPPORT;
+ err = -EAFNOSUPPORT;
goto errout;
}
@@ -365,7 +365,7 @@ static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg)
ops = lookup_rules_ops(net, frh->family);
if (ops == NULL) {
- err = EAFNOSUPPORT;
+ err = -EAFNOSUPPORT;
goto errout;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: net: fib_rules: fix error code for unsupported families
2008-06-30 20:21 net: fib_rules: fix error code for unsupported families Patrick McHardy
@ 2008-07-02 3:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-02 3:00 UTC (permalink / raw)
To: kaber; +Cc: netdev
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 30 Jun 2008 22:21:50 +0200
> net: fib_rules: fix error code for unsupported families
>
> The errno code returned must be negative.
>
> Fixes "RTNETLINK answers: Unknown error 18446744073709551519".
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Applied to net-2.6, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-02 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-30 20:21 net: fib_rules: fix error code for unsupported families Patrick McHardy
2008-07-02 3:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).