netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Chen <wangchen@cn.fujitsu.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Patrick McHardy <kaber@trash.net>, NETDEV <netdev@vger.kernel.org>
Subject: v2 [PATCH net-next 5/7] ipv4: Check return of dev_set_allmulti
Date: Tue, 01 Jul 2008 11:27:38 +0800	[thread overview]
Message-ID: <4869A42A.2010009@cn.fujitsu.com> (raw)
In-Reply-To: <4869A251.108@cn.fujitsu.com>

allmulti might overflow.
Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes
dev_set_promiscuity/allmulti return error number if overflow happened.

Here, we check the positive increment for allmulti to get error return.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
 net/ipv4/ipmr.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index 11700a4..ba0280f 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -398,6 +398,7 @@ static int vif_add(struct vifctl *vifc, int mrtsock)
 	struct vif_device *v = &vif_table[vifi];
 	struct net_device *dev;
 	struct in_device *in_dev;
+	int err;
 
 	/* Is vif busy ? */
 	if (VIF_EXISTS(vifi))
@@ -435,7 +436,9 @@ static int vif_add(struct vifctl *vifc, int mrtsock)
 	if ((in_dev = __in_dev_get_rtnl(dev)) == NULL)
 		return -EADDRNOTAVAIL;
 	IPV4_DEVCONF(in_dev->cnf, MC_FORWARDING)++;
-	dev_set_allmulti(dev, +1);
+	err = dev_set_allmulti(dev, 1);
+	if (err)
+		return err;
 	ip_rt_multicast_event(in_dev);
 
 	/*
-- 1.5.3.4 


  parent reply	other threads:[~2008-07-01  3:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01  3:19 [PATCH net-next 0/7] Check return of dev_set_promiscuity/allmulti Wang Chen
2008-07-01  3:21 ` v2 [PATCH net-next 1/8] af_packet: " Wang Chen
2008-07-01  3:31   ` Wang Chen
2008-07-02  2:56     ` David Miller
2008-07-01  9:36   ` Patrick McHardy
2008-07-01  9:42     ` Wang Chen
2008-07-02  8:12     ` v3 [PATCH net-next 1/7] " Wang Chen
2008-07-02 12:53       ` Patrick McHardy
2008-07-01  3:23 ` v2 [PATCH net-next 2/7] bonding: " Wang Chen
2008-07-02  8:15   ` Wang Chen
2008-07-01  3:25 ` v2 [PATCH net-next 3/7] bridge: Check return of dev_set_promiscuity Wang Chen
2008-07-02  8:15   ` Wang Chen
2008-07-01  3:26 ` v2 [PATCH net-next 4/7] ipv6: Check return of dev_set_allmulti Wang Chen
2008-07-01  9:39   ` Patrick McHardy
2008-07-01  9:44     ` Wang Chen
2008-07-02  8:17     ` v3 " Wang Chen
2008-07-02 12:54       ` Patrick McHardy
2008-07-03  3:23         ` v4 " Wang Chen
2008-07-01  3:27 ` Wang Chen [this message]
2008-07-01  9:40   ` v2 [PATCH net-next 5/7] ipv4: " Patrick McHardy
2008-07-01  9:49     ` Wang Chen
2008-07-01  9:57       ` Patrick McHardy
2008-07-02  8:24     ` v3 " Wang Chen
2008-07-02 12:55       ` Patrick McHardy
2008-07-03  3:25         ` v4 " Wang Chen
2008-07-03  4:13           ` David Miller
2008-07-01  3:28 ` v2 [PATCH net-next 6/7] macvlan: " Wang Chen
2008-07-01  3:30 ` v2 [PATCH net-next 7/7] 8021q: Check return of dev_set_promiscuity/allmulti Wang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4869A42A.2010009@cn.fujitsu.com \
    --to=wangchen@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).