From: Patrick McHardy <kaber@trash.net>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: "David S. Miller" <davem@davemloft.net>, NETDEV <netdev@vger.kernel.org>
Subject: Re: v2 [PATCH net-next 5/7] ipv4: Check return of dev_set_allmulti
Date: Tue, 01 Jul 2008 11:57:13 +0200 [thread overview]
Message-ID: <4869FF79.1060803@trash.net> (raw)
In-Reply-To: <4869FDB3.1040400@cn.fujitsu.com>
Wang Chen wrote:
> Patrick McHardy said the following on 2008-7-1 17:40:
>> Wang Chen wrote:
>>> - dev_set_allmulti(dev, +1);
>>> + err = dev_set_allmulti(dev, 1);
>>> + if (err)
>>> + return err;
>> Missing error handling for VIFF_REGISTER and VIFF_TUNNEL case.
>>
>
> will do.
Thanks. I didn't check the other patches (except those
I ACKed). Please also verify wether they all do error
handling properly.
> seems
>> if ((in_dev = __in_dev_get_rtnl(dev)) == NULL)
> should do error handling too.
Doesn't seem necessary, it doesn't take a reference or has
any other sideeffects.
next prev parent reply other threads:[~2008-07-01 9:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 3:19 [PATCH net-next 0/7] Check return of dev_set_promiscuity/allmulti Wang Chen
2008-07-01 3:21 ` v2 [PATCH net-next 1/8] af_packet: " Wang Chen
2008-07-01 3:31 ` Wang Chen
2008-07-02 2:56 ` David Miller
2008-07-01 9:36 ` Patrick McHardy
2008-07-01 9:42 ` Wang Chen
2008-07-02 8:12 ` v3 [PATCH net-next 1/7] " Wang Chen
2008-07-02 12:53 ` Patrick McHardy
2008-07-01 3:23 ` v2 [PATCH net-next 2/7] bonding: " Wang Chen
2008-07-02 8:15 ` Wang Chen
2008-07-01 3:25 ` v2 [PATCH net-next 3/7] bridge: Check return of dev_set_promiscuity Wang Chen
2008-07-02 8:15 ` Wang Chen
2008-07-01 3:26 ` v2 [PATCH net-next 4/7] ipv6: Check return of dev_set_allmulti Wang Chen
2008-07-01 9:39 ` Patrick McHardy
2008-07-01 9:44 ` Wang Chen
2008-07-02 8:17 ` v3 " Wang Chen
2008-07-02 12:54 ` Patrick McHardy
2008-07-03 3:23 ` v4 " Wang Chen
2008-07-01 3:27 ` v2 [PATCH net-next 5/7] ipv4: " Wang Chen
2008-07-01 9:40 ` Patrick McHardy
2008-07-01 9:49 ` Wang Chen
2008-07-01 9:57 ` Patrick McHardy [this message]
2008-07-02 8:24 ` v3 " Wang Chen
2008-07-02 12:55 ` Patrick McHardy
2008-07-03 3:25 ` v4 " Wang Chen
2008-07-03 4:13 ` David Miller
2008-07-01 3:28 ` v2 [PATCH net-next 6/7] macvlan: " Wang Chen
2008-07-01 3:30 ` v2 [PATCH net-next 7/7] 8021q: Check return of dev_set_promiscuity/allmulti Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4869FF79.1060803@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).