From: Max Krasnyansky <maxk@qualcomm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, markmc@redhat.com,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/4] tun: TUNSETFEATURES to set gso features.
Date: Tue, 01 Jul 2008 22:02:00 -0700 [thread overview]
Message-ID: <486B0BC8.4000601@qualcomm.com> (raw)
In-Reply-To: <200806260029.40267.rusty@rustcorp.com.au>
Rusty Russell wrote:
> ethtool is useful for setting (some) device fields, but it's
> root-only. Finer feature control is available through a tun-specific
> ioctl.
>
> (Includes Mark McLoughlin <markmc@redhat.com>'s fix to hold rtnl sem).
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Agree. And it's often way more convenient to muck with the TUN settings
directly on the fd instead of using external tool.
Acked-by: Max Krasnyansky <maxk@qualcomm.com>
next prev parent reply other threads:[~2008-07-02 5:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 14:28 [PATCH 1/4] tun: Interface to query tun/tap features Rusty Russell
2008-06-25 14:29 ` [PATCH 2/4] tun: TUNSETFEATURES to set gso features Rusty Russell
2008-06-25 14:30 ` [PATCH 3/4] tun: Allow GSO using virtio_net_hdr Rusty Russell
2008-06-25 14:32 ` [PATCH 4/4] lguest: Use GSO/IFF_VNET_HDR extensions on tun/tap Rusty Russell
2008-06-25 15:45 ` Rusty Russell
[not found] ` <200806260032.12359.rusty__46755.7742762894$1214404667$gmane$org@rustcorp.com.au>
2008-06-25 19:07 ` Anthony Liguori
2008-06-26 4:40 ` Rusty Russell
2008-06-26 18:16 ` Anthony Liguori
2008-06-27 3:50 ` Rusty Russell
2008-07-02 5:25 ` Max Krasnyansky
2008-07-02 5:13 ` [PATCH 3/4] tun: Allow GSO using virtio_net_hdr Max Krasnyansky
2008-07-02 7:00 ` Rusty Russell
2008-07-24 14:20 ` Herbert Xu
2008-07-24 23:54 ` Rusty Russell
2008-07-02 5:02 ` Max Krasnyansky [this message]
2008-07-02 4:59 ` [PATCH 1/4] tun: Interface to query tun/tap features Max Krasnyansky
2008-07-02 5:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B0BC8.4000601@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).