From: Martin Devera <devik@cdi.cz>
To: kaber@trash.net
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC]: net-sched 00/05: dynamically sized class hashes
Date: Wed, 02 Jul 2008 08:54:39 +0200 [thread overview]
Message-ID: <486B262F.2040108@cdi.cz> (raw)
In-Reply-To: <20080701.195050.177373433.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Tue, 1 Jul 2008 16:34:11 +0200 (MEST)
>
>> Only RFC at this point because they haven't been tested thoroughly yet
>> and depend on the filter destruction fixes I sent this morning, but any
>> review (especially of 4/5, the htb_delete changes) is welcome.
>
> These patches look fine to me.
>
> I haven't investigated the correctness of the details of patch
> 4 yet, sorry :-) Maybe someone else will be able to.
>
It seems ok to me. I even can't remember why to destroy in class order :-)
Interestingly, once you do this patch then children/siblings list-heads
are used only in htb_parent_last_child and to detect empty class.
Thus we could remove children/siblings lists altogether ane keep only
children counter.
I can't believe it is so simple, what do you think, Patrick ?
Martin
next prev parent reply other threads:[~2008-07-02 6:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 14:34 [RFC]: net-sched 00/05: dynamically sized class hashes Patrick McHardy
2008-07-01 14:34 ` net-sched 01/05: add dynamically sized qdisc class hash helpers Patrick McHardy
2008-07-03 12:18 ` Jarek Poplawski
2008-07-03 12:16 ` Patrick McHardy
2008-07-01 14:34 ` net-sched 02/05: sch_hfsc: use dynamic " Patrick McHardy
2008-07-01 14:34 ` net-sched 03/05: sch_cbq: " Patrick McHardy
2008-07-01 14:34 ` net-sched 04/05: sch_htb: move hash and sibling list removal to htb_delete Patrick McHardy
2008-07-02 8:15 ` Jarek Poplawski
2008-07-02 10:11 ` Patrick McHardy
2008-07-02 12:16 ` Jarek Poplawski
2008-07-02 12:25 ` Patrick McHardy
2008-07-02 21:14 ` Jarek Poplawski
2008-07-03 11:53 ` Patrick McHardy
2008-07-01 14:34 ` net-sched 05/05: sch_htb: use dynamic class hash helpers Patrick McHardy
2008-07-02 21:31 ` Jarek Poplawski
2008-07-03 11:55 ` Patrick McHardy
2008-07-02 2:50 ` [RFC]: net-sched 00/05: dynamically sized class hashes David Miller
2008-07-02 6:54 ` Martin Devera [this message]
2008-07-02 10:13 ` Patrick McHardy
2008-07-02 14:21 ` Patrick McHardy
2008-07-02 14:27 ` Martin Devera
2008-07-02 14:30 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B262F.2040108@cdi.cz \
--to=devik@cdi.cz \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).