From: Thomas Klein <osstklei@de.ibm.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, themann@de.ibm.com
Subject: Re: [PATCH] ehea: Access iph->tot_len with correct endianness
Date: Wed, 02 Jul 2008 16:45:37 +0200 [thread overview]
Message-ID: <486B9491.4020004@de.ibm.com> (raw)
In-Reply-To: <ada7ic5ed26.fsf@cisco.com>
Roland Dreier wrote:
> iph->tot_len is stored in network byte order, so access it using
> ntohs(). This doesn't have any real world impact on ehea, since ehea
> only exists for big-endian platfroms (at the moment at least) but fixing
> this gets rid of a sparse warning and avoids having a bad example in the
> tree.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> drivers/net/ehea/ehea_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> index 075fd54..451b7e6 100644
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -616,7 +616,7 @@ static int get_skb_hdr(struct sk_buff *skb, void **iphdr,
> *tcph = tcp_hdr(skb);
>
> /* check if ip header and tcp header are complete */
> - if (iph->tot_len < ip_len + tcp_hdrlen(skb))
> + if (ntohs(iph->tot_len) < ip_len + tcp_hdrlen(skb))
> return -1;
>
> *hdr_flags = LRO_IPV4 | LRO_TCP;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Correct. Thanks Roland!
Acked-by: Thomas Klein <tklein@de.ibm.com>
next prev parent reply other threads:[~2008-07-02 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:20 [PATCH] ehea: Access iph->tot_len with correct endianness Roland Dreier
2008-07-02 14:45 ` Thomas Klein [this message]
2008-07-04 12:15 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B9491.4020004@de.ibm.com \
--to=osstklei@de.ibm.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=themann@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).