netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Chen <wangchen-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vinay-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	krkumar2-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org,
	mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	Matheos.Worku-UdXhSnd/wVw@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 06/39]: netdev: ->ingress_lock is no longer needed.
Date: Thu, 03 Jul 2008 18:01:18 +0800	[thread overview]
Message-ID: <486CA36E.60704@cn.fujitsu.com> (raw)
In-Reply-To: <20080703.030241.34728979.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

David Miller said the following on 2008-7-3 18:02:
> From: Wang Chen <wangchen-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Date: Thu, 03 Jul 2008 17:55:30 +0800
> 
>> David Miller said the following on 2008-7-3 15:03:
>>> @@ -2014,10 +2014,11 @@ static inline struct sk_buff *handle_macvlan(struct sk_buff *skb,
>>>   */
>>>  static int ing_filter(struct sk_buff *skb)
>>>  {
>>> -	struct Qdisc *q;
>>>  	struct net_device *dev = skb->dev;
>>> -	int result = TC_ACT_OK;
>>>  	u32 ttl = G_TC_RTTL(skb->tc_verd);
>>> +	struct netdev_queue *rxq;
>>> +	int result = TC_ACT_OK;
>>> +	struct Qdisc *q;
>>>  
>> Two lines do not change anything.
> 
> They make the variables have a nice style slope from longest
> lines to the shortest.
> 

Understood now :)

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2008-07-03 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03  7:03 [PATCH 06/39]: netdev: ->ingress_lock is no longer needed David Miller
     [not found] ` <20080703.000303.167904111.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-03  9:55   ` Wang Chen
2008-07-03 10:02     ` David Miller
     [not found]       ` <20080703.030241.34728979.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-03 10:01         ` Wang Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486CA36E.60704@cn.fujitsu.com \
    --to=wangchen-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
    --cc=Matheos.Worku-UdXhSnd/wVw@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=krkumar2-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vinay-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).