From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 01/15] kobject: Cleanup kobject_rename and !CONFIG_SYSFS Date: Fri, 04 Jul 2008 15:33:23 +0900 Message-ID: <486DC433.9040200@gmail.com> References: <20080618170729.808539948@theryb.frec.bull.fr> <20080618170731.002784342@theryb.frec.bull.fr> <485F04E1.70204@gmail.com> <486706C9.9040303@gmail.com> <4869D314.5030403@gmail.com> <486A0751.9080602@gmail.com> <486AF4FA.8020805@gmail.com> <486B060C.7030607@gmail.com> <486C4515.1070007@gmail.com> <486CB051.5000507@fr.ibm.com> <486CF71F.5090405@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg Kroah-Hartman , Andrew Morton , Daniel Lezcano , linux-kernel@vger.kernel.org, Al Viro , Linux Containers , Benjamin Thery , netdev@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from rv-out-0506.google.com ([209.85.198.232]:24462 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756032AbYGDGeR (ORCPT ); Fri, 4 Jul 2008 02:34:17 -0400 Received: by rv-out-0506.google.com with SMTP id k40so1390035rvb.1 for ; Thu, 03 Jul 2008 23:34:17 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Eric W. Biederman wrote: > It finally dawned on me what the clean fix to sysfs_rename_dir > calling kobject_set_name is. Move the work into kobject_rename > where it belongs. The callers serialize us anyway so this is > safe. > > Signed-off-by: Eric W. Biederman Nice clean up. Acked-by: Tejun Heo -- tejun