netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
	benh@kernel.crashing.org, Sathya Narayanan <sathyan@teamf1.com>
Subject: Re: [PATCH v2] ibm_newemac: Fixes entry of short packets
Date: Fri, 04 Jul 2008 08:17:39 -0400	[thread overview]
Message-ID: <486E14E3.6080402@garzik.org> (raw)
In-Reply-To: <1214902699-10534-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
> From: Sathya Narayanan <sathyan@teamf1.com>
> 
> Short packets has to be discarded by the driver. So this patch addresses the
> issue of discarding the short packets of size lesser then ethernet header
> size.
> 
> Signed-off-by: Sathya Narayanan <sathyan@teamf1.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  drivers/net/ibm_newemac/core.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index ca63fa0..babc79a 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -1636,6 +1636,12 @@ static int emac_poll_rx(void *param, int budget)
>  			goto next;
>  		}
>  
> +		if (len < ETH_HLEN) {
> +			++dev->estats.rx_dropped_stack;
> +			emac_recycle_rx_skb(dev, slot, len);
> +			goto next;
> +		}
> +
>  		if (len && len < EMAC_RX_COPY_THRESH) {

applied 2.6.26



      reply	other threads:[~2008-07-04 12:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01  8:58 [PATCH v2] ibm_newemac: Fixes entry of short packets Stefan Roese
2008-07-04 12:17 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486E14E3.6080402@garzik.org \
    --to=jeff@garzik.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=sathyan@teamf1.com \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).