From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [NET-NEXT PATCH 17/18] net: add netif_napi_del
 function to allow for	removal of napistructs
Date: Fri, 04 Jul 2008 08:42:25 -0400
Message-ID: <486E1AB1.30902@garzik.org>
References: <20080627175921.22428.52767.stgit@localhost.localdomain>
	<20080627180200.22428.70787.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	linux-kernel@vger.kernel.org
To: davem@davemloft.net
Return-path: <e1000-devel-bounces@lists.sourceforge.net>
In-Reply-To: <20080627180200.22428.70787.stgit@localhost.localdomain>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/e1000-devel>,
	<mailto:e1000-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=e1000-devel>
List-Post: <mailto:e1000-devel@lists.sourceforge.net>
List-Help: <mailto:e1000-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/e1000-devel>,
	<mailto:e1000-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: e1000-devel-bounces@lists.sourceforge.net
Errors-To: e1000-devel-bounces@lists.sourceforge.net
List-Id: netdev.vger.kernel.org

Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> Adds netif_napi_del function which is used to remove the napi struct from
> the netdev napi_list in cases where CONFIG_NETPOLL was enabled.
> The motivation for adding this is to handle the case in which the number of
> queues on a device changes due to a configuration change.  Previously the
> napi structs for each queue would be left in the list until the netdev was
> freed.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> 
>  include/linux/netdevice.h |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 1304ad2..42fc98e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -826,6 +826,19 @@ static inline void netif_napi_add(struct net_device *dev,
>  	set_bit(NAPI_STATE_SCHED, &napi->state);
>  }
>  
> +/**
> + *  netif_napi_del - remove a napi context
> + *  @napi: napi context
> + *
> + *  netif_napi_del() removes a napi context from the network device napi list
> + */
> +static inline void netif_napi_del(struct napi_struct *napi)
> +{
> +#ifdef CONFIG_NETPOLL
> +	list_del(&napi->dev_list);
> +#endif
> +}
> +

David - ACK?

I would prefer to throw this in with the 18-patch igb pile, if that's OK 
with you.


-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08