From: Sven Eckelmann <sven@narfation.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, a@unstable.cc, sw@simonwunderlich.de,
mareklindner@neomailbox.ch
Subject: Re: [PATCH next] sched: remove NET_XMIT_POLICED
Date: Fri, 10 Jun 2016 18:30:23 +0200 [thread overview]
Message-ID: <4871472.EuzojNRMXg@bentobox> (raw)
In-Reply-To: <1465561289-15401-1-git-send-email-fw@strlen.de>
[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]
On Friday 10 June 2016 14:21:29 Florian Westphal wrote:
[...]
> BATMAN uses it as an intermediate return value to signal
> forwarding vs. buffering, but it will not return POLICED to
> callers outside of BATMAN.
[...]
> diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c
> index f2f1256..b1a4e8a 100644
> --- a/net/batman-adv/send.c
> +++ b/net/batman-adv/send.c
> @@ -156,7 +156,7 @@ int batadv_send_unicast_skb(struct sk_buff *skb,
> * attempted.
> *
> * Return: NET_XMIT_SUCCESS on success, NET_XMIT_DROP on failure, or
> - * NET_XMIT_POLICED if the skb is buffered for later transmit.
> + * -EINPROGRESS if the skb is buffered for later transmit.
> */
> int batadv_send_skb_to_orig(struct sk_buff *skb,
> struct batadv_orig_node *orig_node,
> @@ -188,7 +188,7 @@ int batadv_send_skb_to_orig(struct sk_buff *skb,
> * network coding fails, then send the packet as usual.
> */
> if (recv_if && batadv_nc_skb_forward(skb, neigh_node)) {
> - ret = NET_XMIT_POLICED;
> + ret = -EINPROGRESS;
> } else {
> batadv_send_unicast_skb(skb, neigh_node);
> ret = NET_XMIT_SUCCESS;
Looks good to me. But it has a minor conflict with a queued up patch
for David (not yet submitted by Antonio). This is not real problem for
you but it looks like there is something wrong with the queued up patch.
I have submitted a fix for it and Antonio should just know that it is
related to this one.
But to your patch:
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-10 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 12:21 [PATCH next] sched: remove NET_XMIT_POLICED Florian Westphal
2016-06-10 14:28 ` Eric Dumazet
2016-06-10 16:30 ` Sven Eckelmann [this message]
2016-06-11 6:31 ` David Miller
2016-06-11 7:00 ` David Miller
2016-06-11 9:06 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4871472.EuzojNRMXg@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=fw@strlen.de \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).