[PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[Subbu Seetharaman]

Signed-off-by: Subbu Seetharaman <subbus@serverengines.com>
---
 MAINTAINERS          |    7 +++++++
 drivers/net/Kconfig  |    8 ++++++++
 drivers/net/Makefile |    1 +
 3 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e6c06fa..9db60d8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3621,6 +3621,13 @@ L:	linux-ide@vger.kernel.org
 T:	git kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
 S:	Supported
 
+SERVER ENGINES 10Gbe NIC - BLADE-ENGINE
+P:	Subbu Seetharaman
+M:	subbus@serverengines.com
+L:	netdev@vger.kernel.org
+W:	http://www.serverengines.com
+S:	Supported
+
 SGI SN-IA64 (Altix) SERIAL CONSOLE DRIVER
 P:	Pat Gefre
 M:	pfg@sgi.com
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f4182cf..78b4d6e 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2581,6 +2581,14 @@ config BNX2X
 
 source "drivers/net/sfc/Kconfig"
 
+config BENET
+	tristate "ServerEngines 10Gb NIC - BladeEngine"
+	depends on PCI
+	select INET_LRO
+	help
+	  This driver implements the NIC functionality for ServerEngines
+	  10Gb network adapter BladeEngine (EC 3210).
+
 endif # NETDEV_10000
 
 source "drivers/net/tokenring/Kconfig"
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index dcbfe84..8f3c1ff 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -18,6 +18,7 @@ obj-$(CONFIG_BONDING) += bonding/
 obj-$(CONFIG_ATL1) += atlx/
 obj-$(CONFIG_GIANFAR) += gianfar_driver.o
 obj-$(CONFIG_TEHUTI) += tehuti.o
+obj-$(CONFIG_BENET) += benet/
 
 gianfar_driver-objs := gianfar.o \
 		gianfar_ethtool.o \
-- 
1.5.5



___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.

Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[Bill Fink]

On Fri, 04 Jul 2008, Subbu Seetharaman wrote:

> Signed-off-by: Subbu Seetharaman <subbus@serverengines.com>
> ---
>  MAINTAINERS          |    7 +++++++
>  drivers/net/Kconfig  |    8 ++++++++
>  drivers/net/Makefile |    1 +
>  3 files changed, 16 insertions(+), 0 deletions(-)

...

> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f4182cf..78b4d6e 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2581,6 +2581,14 @@ config BNX2X
>  
>  source "drivers/net/sfc/Kconfig"
>  
> +config BENET
> +	tristate "ServerEngines 10Gb NIC - BladeEngine"
> +	depends on PCI
> +	select INET_LRO
> +	help
> +	  This driver implements the NIC functionality for ServerEngines
> +	  10Gb network adapter BladeEngine (EC 3210).
> +
>  endif # NETDEV_10000
>  
>  source "drivers/net/tokenring/Kconfig"

I'm no Kconfig expert, but based on previous driver discussions,
I believe the above depends needs to be changed to:

	depends on PCI && INET

to prevent certain build problems that can arise from having just
the "select INET_LRO" clause.

						-Bill

Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[Randy Dunlap]

On Sat, 5 Jul 2008 01:39:33 -0400 Bill Fink wrote:

> On Fri, 04 Jul 2008, Subbu Seetharaman wrote:
> 
> > Signed-off-by: Subbu Seetharaman <subbus@serverengines.com>
> > ---
> >  MAINTAINERS          |    7 +++++++
> >  drivers/net/Kconfig  |    8 ++++++++
> >  drivers/net/Makefile |    1 +
> >  3 files changed, 16 insertions(+), 0 deletions(-)
> 
> ...
> 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index f4182cf..78b4d6e 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2581,6 +2581,14 @@ config BNX2X
> >  
> >  source "drivers/net/sfc/Kconfig"
> >  
> > +config BENET
> > +	tristate "ServerEngines 10Gb NIC - BladeEngine"
> > +	depends on PCI
> > +	select INET_LRO
> > +	help
> > +	  This driver implements the NIC functionality for ServerEngines
> > +	  10Gb network adapter BladeEngine (EC 3210).
> > +
> >  endif # NETDEV_10000
> >  
> >  source "drivers/net/tokenring/Kconfig"
> 
> I'm no Kconfig expert, but based on previous driver discussions,
> I believe the above depends needs to be changed to:
> 
> 	depends on PCI && INET
> 
> to prevent certain build problems that can arise from having just
> the "select INET_LRO" clause.

Correct.  Thanks for catching that.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[Jeff Garzik]

subbu wrote:
> Thanks Randy and Bill.  I will wait couple more
> days for any more comments before sending the updated patch.

Also, if you have a link to a patch that provides everything in one 
file, that would be useful for me.

	Jeff

Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[Subbu Seetharaman]

Jeff,

The benet driver patch with this Kconfig change is available 
as one file under under :

ftp://ftp.serverengines.com/0001.benet.patch

Thanks.

Subbu

----- Original Message -----
From: Jeff Garzik [mailto:jeff@garzik.org]
To: subbu [mailto:subbus@serverengines.com]
Cc: 'Randy Dunlap' [mailto:randy.dunlap@oracle.com], 'Bill Fink' [mailto:billfink@mindspring.com], netdev@vger.kernel.org
Sent: Mon, 07 Jul 2008 06:57:48 -0700
Subject: Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS


subbu wrote:
> Thanks Randy and Bill.  I will wait couple more
> days for any more comments before sending the updated patch.

Also, if you have a link to a patch that provides everything in one 
file, that would be useful for me.

	Jeff

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.

Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

[Subbu Seetharaman]

Jeff,

Has this patch been applied ?  Thanks.

Subbu


-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
Behalf Of Subbu Seetharaman
Sent: Wednesday, July 09, 2008 7:25 AM
To: Jeff Garzik
Cc: 'Randy Dunlap'; 'Bill Fink'; netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS

Jeff,

The benet driver patch with this Kconfig change is available 
as one file under under :

ftp://ftp.serverengines.com/0001.benet.patch

Thanks.

Subbu

----- Original Message -----
From: Jeff Garzik [mailto:jeff@garzik.org]
To: subbu [mailto:subbus@serverengines.com]
Cc: 'Randy Dunlap' [mailto:randy.dunlap@oracle.com], 'Bill Fink'
[mailto:billfink@mindspring.com], netdev@vger.kernel.org
Sent: Mon, 07 Jul 2008 06:57:48 -0700
Subject: Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS


subbu wrote:
> Thanks Randy and Bill.  I will wait couple more
> days for any more comments before sending the updated patch.

Also, if you have a link to a patch that provides everything in one 
file, that would be useful for me.

	Jeff

____________________________________________________________________________
_______
This message, together with any attachment(s), contains confidential and
proprietary information of
ServerEngines Corporation and is intended only for the designated
recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly
prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by
reply email message and
delete all copies of this message and any attachment(s). Thank you.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.